Minor changes for hhvm support. #164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Getting this notice: |
|
Please don't merge this yet, while I work out why the above is happening 😄 |
|
@frankmayer This can be merged. The notices were due to a bug in hhvm 2.3.0 that was fixed in 2.3.1. Unfortunately, travis is using 2.3.0 and there appears to be no way to update it to 2.3.1. When travis updates to 2.3.1, the notices should disappear. |
frankmayer
added a commit
that referenced
this pull request
Dec 22, 2013
Minor changes for hhvm support.
|
Thanks for looking into it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes so we can support hhvm.