Skip to content

DE-752 | multi_delimiter analyzer [3.12] #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 24, 2024
Merged

DE-752 | multi_delimiter analyzer [3.12] #322

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bbeda93
DE-752 | initial commit
aMahanna Feb 2, 2024
b48e105
fix: analyzer type
aMahanna Feb 4, 2024
6e5bc34
fix: analyzer test
aMahanna Mar 8, 2024
5724735
Merge branch 'main' into DE-752
aMahanna Apr 22, 2024
ac2dd4a
fix: `test_analyzer_management`
aMahanna Apr 22, 2024
cc09397
Merge branch 'main' into DE-752
aMahanna Apr 23, 2024
9396887
Merge branch 'main' into DE-752
aMahanna Apr 24, 2024
cd00eee
Merge branch 'main' into DE-752
aMahanna Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion tests/test_analyzer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,23 @@ def test_analyzer_management(db, bad_db, cluster, enterprise, db_version):
full_analyzer_name = db.name + "::" + analyzer_name
bad_analyzer_name = generate_analyzer_name()

# Test create analyzer
# Test create identity analyzer
result = db.create_analyzer(analyzer_name, "identity", {})
assert result["name"] == full_analyzer_name
assert result["type"] == "identity"
assert result["properties"] == {}
assert result["features"] == []

# Test create delimiter analyzer
result = db.create_analyzer(
name=generate_analyzer_name(),
analyzer_type="delimiter",
properties={"delimiter": ","},
)
assert result["type"] == "delimiter"
assert result["properties"] == {"delimiter": ","}
assert result["features"] == []

# Test create duplicate with bad database
with assert_raises(AnalyzerCreateError) as err:
bad_db.create_analyzer(analyzer_name, "identity", {}, [])
Expand Down Expand Up @@ -72,6 +82,18 @@ def test_analyzer_management(db, bad_db, cluster, enterprise, db_version):
}
assert db.delete_analyzer(analyzer_name)

# Test create delimieter analyzer with multiple delimiters
if db_version >= version.parse("3.12.0"):
result = db.create_analyzer(
name=generate_analyzer_name(),
analyzer_type="multi_delimiter",
properties={"delimiters": [",", "."]},
)

assert result["type"] == "multi_delimiter"
assert result["properties"] == {"delimiters": [",", "."]}
assert result["features"] == []

if db_version >= version.parse("3.12.0"):
analyzer_name = generate_analyzer_name()
result = db.create_analyzer(analyzer_name, "wildcard", {"ngramSize": 4})
Expand Down