Skip to content

rebuild-todo: Various improvements #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2024
Merged

rebuild-todo: Various improvements #74

merged 1 commit into from
Jul 6, 2024

Conversation

Antiz96
Copy link
Member

@Antiz96 Antiz96 commented Jul 4, 2024 •
edited
Loading

2024-07-04_23-00

2024-07-04_23-21

polyzen
polyzen reviewed Jul 4, 2024
View reviewed changes
@Antiz96
Copy link
Member Author

Antiz96 commented Jul 4, 2024 •
edited
Loading

Are we interested in an additional listing for released packages as well (which is a separate step from rebuilding)?
There can be some (rather edgy but still existing) cases where the build can success but not the release/publish.

If you feel that could be interesting, I can add it to that PR.

@alerque
Copy link
Member

alerque commented Jul 4, 2024

The edge case of failed releases for successful builds may be useful, but ever more useful to me would be a list of failed (skipped) builds. Two lists here would be really nice: skipped & built/published. Or three if you do add the other feature: skipped, built (e.g. only built not published), and published.

alerque
alerque reviewed Jul 4, 2024
View reviewed changes
@Antiz96
Copy link
Member Author

Antiz96 commented Jul 4, 2024 •
edited
Loading

The edge case of failed releases for successful builds may be useful, but ever more useful to me would be a list of failed (skipped) builds. Two lists here would be really nice: skipped & built/published. Or three if you do add the other feature: skipped, built (e.g. only built not published), and published.

The 3 lists thing should be doable (skipped, built only but not published, and published). I'll try to work on that when I can. Thanks for the suggestion :)
I'm converting this PR as a draft in the mean time.

@Antiz96 Antiz96 marked this pull request as draft July 4, 2024 20:08
@Antiz96 Antiz96 changed the title rebuilt-todo: Print a message during pkg list parsing, better confirm message and show exact list of rebuilt pkg when done rebuilb-todo: Print a message during pkg list parsing, better confirm message and show exact list of rebuilt pkg when done Jul 4, 2024
@Antiz96 Antiz96 changed the title rebuilb-todo: Print a message during pkg list parsing, better confirm message and show exact list of rebuilt pkg when done rebuild-todo: Print a message during pkg list parsing, better confirm message and show exact list of rebuilt pkg when done Jul 4, 2024
@Antiz96 Antiz96 changed the title rebuild-todo: Print a message during pkg list parsing, better confirm message and show exact list of rebuilt pkg when done rebuild-todo: Print a message during pkg list parsing, better confirm message and show exact list of skipped, rebuilt and released pkg when done Jul 4, 2024
@Antiz96 Antiz96 changed the title rebuild-todo: Print a message during pkg list parsing, better confirm message and show exact list of skipped, rebuilt and released pkg when done rebuild-todo: Print a message during pkg list parsing, better confirm message and show exact list of skipped, rebuilt and released packages when done Jul 4, 2024
@Antiz96 Antiz96 changed the title rebuild-todo: Print a message during pkg list parsing, better confirm message and show exact list of skipped, rebuilt and released packages when done rebuild-todo: Print a message during packages list parsing, better confirm message and show exact list of skipped, rebuilt and released packages when done Jul 4, 2024
@Antiz96 Antiz96 changed the title rebuild-todo: Print a message during packages list parsing, better confirm message and show exact list of skipped, rebuilt and released packages when done rebuild-todo: Various improvements Jul 4, 2024
@Antiz96 Antiz96 marked this pull request as ready for review July 4, 2024 23:35
@Antiz96 Antiz96 requested review from alerque, Foxboron and polyzen July 4, 2024 23:35
@Foxboron
Copy link
Member

Foxboron commented Jul 5, 2024

Cool, this looks great :) Thanks!

@Antiz96
rebuild-todo: Various improvements
8dc888c 
- Print a message during the packages list parsing (to avoid thinking the script is just stuck)

- Improve the "confirm" message: fixes #54

- Don't exit on failed release

- Show the exact list of skipped packages (that failed to build), rebuilt packages (but unreleased) and released packages when done: fixes #53
christian-heusel
christian-heusel reviewed Jul 6, 2024
View reviewed changes
@jelly jelly merged commit 655a2fa into archlinux:master Jul 6, 2024
@Antiz96 Antiz96 deleted the various_improvements_rebuild_todo branch July 6, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-heusel christian-heusel christian-heusel left review comments

@jelly jelly jelly approved these changes

@alerque alerque alerque approved these changes

@Foxboron Foxboron Foxboron approved these changes

@polyzen polyzen polyzen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rebuild-todo: confirm option is a bit vague rebuild-todo: show list of rebuild packages when done
6 participants
@Antiz96 @alerque @Foxboron @jelly @polyzen @christian-heusel