Skip to content

EthernetClient flush() is pre-1.0 input discard #1576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
PaulStoffregen opened this issue Sep 15, 2013 · 2 comments
Closed

EthernetClient flush() is pre-1.0 input discard #1576

PaulStoffregen opened this issue Sep 15, 2013 · 2 comments
Assignees
@cmaglie
Labels
Component: Core Related to the code for the standard Arduino API Library: Ethernet The Ethernet Arduino library

Comments

@PaulStoffregen
Copy link
Contributor

EthernetClient.cpp in 1.5.x has old pre-1.0 flush() function that discards input. Arduino 1.0 changed flush() to complete transmission.

https://github.com/arduino/Arduino/blob/ide-1.5.x/libraries/Ethernet/src/EthernetClient.cpp#L122

void EthernetClient::flush() {
while (available())
read();
}
@ghost ghost assigned cmaglie Sep 17, 2013
cmaglie added a commit that referenced this issue Sep 25, 2013
@cmaglie
Fixed wrong behaviour of EthernetClient::flush().
88def54 
Fixes #1576
@cmaglie
Copy link
Member

cmaglie commented Sep 25, 2013

Fixed the wrong behaviour of dropping buffered chars, but I'm not sure that the flush waits for real the end of transmission. I should write a test for it.

@cmaglie cmaglie modified the milestones: Release 1.5.7, Release 1.5.6 Feb 21, 2014
@ffissore ffissore added the New label Feb 27, 2014
@cmaglie cmaglie removed the New label Feb 27, 2014
@cmaglie cmaglie modified the milestones: Release 1.5.8, Release 1.5.7 Jul 2, 2014
@cmaglie cmaglie modified the milestones: Release 1.5.9, Release 1.5.8 Sep 12, 2014
@cmaglie cmaglie modified the milestones: Release 1.6.0, Release 1.6.1 Feb 18, 2015
@ffissore ffissore modified the milestones: Release 1.6.1, Release 1.6.5 May 20, 2015
@ffissore ffissore modified the milestones: Release 1.6.5, Release 1.6.6 Jun 15, 2015
@ffissore ffissore modified the milestones: Release 1.6.6, 1.6.7 Nov 4, 2015
@ffissore ffissore modified the milestone: Release 1.6.7 Dec 14, 2015
@sandeepmistry sandeepmistry added the Library: Ethernet The Ethernet Arduino library label Jul 12, 2016
@agdl agdl mentioned this issue Jul 12, 2016
Open
@agdl
Copy link
Member

agdl commented Jul 12, 2016

This issue was moved to arduino-libraries/Ethernet#27

@agdl agdl closed this as completed Jul 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmaglie cmaglie

Labels
Component: Core Related to the code for the standard Arduino API Library: Ethernet The Ethernet Arduino library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@cmaglie @ffissore @PaulStoffregen @sandeepmistry @agdl