this closes issue #2198 #2486
Closed
this closes issue #2198 #2486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an analog input is used and during the sketch modified in a digitalOutput
the pinMode(AX, OUTPUT) isn't sensed because of this line of codes:
wiring_analog.c line 135
// Enable the corresponding channel
if (ulChannel != latestSelectedChannel) {
adc_enable_channel( ADC, ulChannel );
if ( latestSelectedChannel != (uint32_t)-1 )
adc_disable_channel( ADC, latestSelectedChannel );
latestSelectedChannel = ulChannel;
The channel is infact enabled only if different from the previous one because
of speed problems.
With my patch:
when pinMode(PIN, OUTPUT) is declared a control about if the pin
is an analog one is done and if so the ADC is released
when pinMode(PIN, INPUT) is declared a control is as well done in order to
enable the ADC.
|
@ArduinoBot build this please |
|
some thoughts and tests here https://groups.google.com/a/arduino.cc/forum/#!topic/developers/IdhTIT0V5GY |
|
Closing because the solution has the side effect to break digitalRead() on analog pins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this way the problem doesn't subsist any more because pinMode checks if pin is digital and if so disable ADC when pin is declared as OUTPUT and enable it if declared as INPUT