Fixed behaviour in the falling phase PJ03 StarterKit #3326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to arduino#2585 there was a "glitch" in the falling phase because of a missing +2 in the first condition
ffissore
added a commit
that referenced
this pull request
Jun 12, 2015
Fixed behaviour in the falling phase PJ03 StarterKit
|
In the future, can we please try to have a bit more meaningful commit messages? They should be self-contained and make sense without having to look at the diff and file list, as far as I'm concerned. In this case, an indication that it applies to an example for this starter kit would be great, as well as some guidance as to what this "falling phase" is... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #2585 there was a "glitch" in the falling phase because of a missing +2 in the first condition