I think the ^= and ! should be explained then. Maybe even add the old one as a comment and tell that those two pieces of code are the same.

@Avamander the examples are intended for people who want to understand programming and are written in the easiest as possible for this reason, so I'm sorry but this PR won't be merged..

FYI: Not my pull request.

These examples are for absolute beginners and the "compact" version adds complexity (even more using ^= that introduce two new concepts in a row: the XOR and the compound assignment).

@tigoe @SimonePDA @shfitz
should we clarify this is in a FAQ? This is the 3rd PR this month that tries to improve the examples, maybe we should think about a reorganization of the base examples and add a "contribution guidelines".

@Avamander sorry wrong tag, it was for @ComputerNerd

add a "contribution guidelines".

See #3368

@cmaglie, yes I agree, a FAQ would be good. We have this: https://www.arduino.cc/en/Reference/StyleGuide Which you could add do and/or make more prominent.

@cmaglie Is it just the XOR compound assignment that you object to? It could also be written as

ledState = !ledState;

If you like the other changes I could rebase my commit to not use the XOR compound assignment and use either the above alternative or bring back the if statements.

Me personally, I'd leave all the logical operators out of this example and introduce them later. For someone who's seeing their first if() statement, that's enough to deal with. Conciseness is less a priority for these examples than illustrating one clear concept per example.

If you want to write some examples that illustrate and explain the logical operators, though, I think that'd be great.