resolving issue 6132 (option to enable/disable auto-curly-brace, editor.autocomplete option) #6155
Conversation
|
The diff on line 601/603 is Git's normal behavior when there's no newline at the end of a file. It's very annoying when files have this problem and they should all be fixed but that should occur in a separate pull request/commit as it is separate from this change. It's better to use descriptive commit titles and messages rather than just referring to an issue number so that the reason for the commit can be easily seen at a glance rather than having to go dig up an issue report. I really think it will be a good improvement to make the automatic addition of closing braces optional. I would like to try it out if we can get @ArduinoBot to do a build. |
|
good idea, I edited the title of the issue. I uploaded a patch in #6129 as part of a running commentary on that one (which is incorporated in this one). If you did a 'git pull' on the repository right now, and applied that patch, then build with 'ant build' and run with 'ant start' you should get both fixes. then edit your local user's 'preferences.txt' and change editor.autocomplete to 'false'. Or you could do a shallow clone on my forked repo in github.com/bombasticbob/Arduino [shallow to save time] which I used to generate the pull request. Anyway, more people please try and comment thanks, and perhaps it will be expedited? (or if you have a better name for the setting, same idea) |
@facchinm
@matthijskooijman
this pull request resolves issue #6132 by adding a new element 'editor.autocomplete' with default value of 'true' to 'preferences.txt', implementing it in 'EditorTab.java'. It also incorporates the change for #6129 in the merge.
Please review, including the naming of the 'edit.autocomplete' setting in preferences.txt, and incorporate (and document) this change in the next official revision. Thank you.
(for some odd reason there is an edit on line 601/603 that wasn't intended, seems to get rid of some trailing white space on a curly brace, or similar, might have been inadvertently caused by pluma)