Skip to content

Preferences: arrange checkboxes into two columns #8638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 2, 2019
Merged

Preferences: arrange checkboxes into two columns #8638

merged 3 commits into from
Apr 2, 2019

Conversation

facchinm
Copy link
Member

Should fix #8238

I'm not a huge fan of this layout (it could be problematic for some translations) but it's one of the solutions.

@tigoe @mbanzi @cmaglie @sandeepmistry any thought?

Screenshot attached for the lazies 😉
2019-03-11-173257_850x504_scrot

@facchinm facchinm added the Component: IDE user interface The Arduino IDE's user interface label Mar 11, 2019
@facchinm facchinm added this to the Release 1.8.9 milestone Mar 11, 2019
@ArduinoBot
Copy link
Contributor

✅ Build completed.

Please test this code using one of the following:

⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-8638-BUILD-834-linux32.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-8638-BUILD-834-linux64.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-8638-BUILD-834-windows.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-8638-BUILD-834-macosx.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-8638-BUILD-834-linuxarm.tar.xz

ℹ️ The linuxarm build is still experimental and may not be always available.

@PaulStoffregen
Copy link
Contributor

Is "Update sketch files to new extension on save" still needed in the UI, more than 7 years after adding the .ino in version 1.0?

Is "Aggressively cache compiled core" really needed as a user visible setting?

@facchinm
Copy link
Member Author

@PaulStoffregen I agree with both your concerns; when core caching was introduced I feared it could have side effects so I pushed to introduce the flag (I think it can be safely removed now since no bug related to that functionality was ever reported).
Same applies to pde -> ino , I'd keep it s default and hide in the UI.

@tigoe
Copy link
Member

tigoe commented Mar 12, 2019

I'm good with both of Paul's suggestions.

@facchinm facchinm force-pushed the dual_column_preferences branch from 035c9b2 to e8088ef Compare March 12, 2019 13:31
@ArduinoBot
Copy link
Contributor

✅ Build completed.

Please test this code using one of the following:

⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-8638-BUILD-836-linux32.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-8638-BUILD-836-linux64.tar.xz
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-8638-BUILD-836-windows.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-8638-BUILD-836-macosx.zip
⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-8638-BUILD-836-linuxarm.tar.xz

ℹ️ The linuxarm build is still experimental and may not be always available.

@cmaglie cmaglie merged commit 26f4283 into arduino:master Apr 2, 2019
@cmaglie cmaglie deleted the dual_column_preferences branch April 2, 2019 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: IDE user interface The Arduino IDE's user interface
Projects
None yet
Milestone
Release 1.8.10
Development

Successfully merging this pull request may close these issues.

Can't access buttons on Preferences window on screens with vertical resolution of 600 px (again)
5 participants
@facchinm @ArduinoBot @PaulStoffregen @tigoe @cmaglie