Skip to content

Remove forceful "using namespace arduino" from headers #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2021
Merged

Remove forceful "using namespace arduino" from headers #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db53d3d
Remove forceful "using namespace arduino" from headers
facchinm Mar 29, 2021
f66d9dc
Fix CI without explicit Arduino.h include
facchinm Apr 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/Print.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,4 +93,4 @@ class Print
};

}
using namespace arduino;
using arduino::Print;
3 changes: 3 additions & 0 deletions api/String.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,5 +255,8 @@ class StringSumHelper : public String

} // namespace arduino

using arduino::__FlashStringHelper;
using arduino::String;

#endif // __cplusplus
#endif // __ARDUINO_STRINGS__
4 changes: 1 addition & 3 deletions api/Udp.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,4 @@ class UDP : public Stream {
uint8_t* rawIPAddress(IPAddress& addr) { return addr.raw_address(); };
};

}

using namespace arduino;
}
2 changes: 2 additions & 0 deletions test/src/Stream/test_parseFloat.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@

#include <float.h>

using namespace arduino;

/**************************************************************************************
* TEST CODE
**************************************************************************************/
Expand Down
2 changes: 2 additions & 0 deletions test/src/Stream/test_parseInt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
* TEST CODE
**************************************************************************************/

using namespace arduino;

TEST_CASE ("Testing parseInt(LookaheadMode lookahead = SKIP_ALL, char ignore = NO_IGNORE_CHAR)", "[Stream-parseInt-01]")
{
StreamMock mock;
Expand Down