Skip to content

Fix buffer sync issue in camera raw bytes example #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 23, 2021
Merged

Fix buffer sync issue in camera raw bytes example #143

merged 8 commits into from
Feb 23, 2021

Conversation

sebromero
Copy link
Collaborator

Adds a very basic synchronization to the Arduino and Processing sketch to make sure the buffer doesn't get out of sync.
Here is the before / after comparison:

Before

After

@sebromero sebromero changed the title Camera example Fix buffer sync issue in camera raw bytes example Feb 22, 2021
@sebromero sebromero requested a review from facchinm February 22, 2021 11:37
@sebromero
Copy link
Collaborator Author

@iabdalkader Wdyt?

@github-actions
Copy link

Memory usage change @ 198d296

Board flash % RAM for global variables %
arduino:mbed:envie_m4 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed:envie_m7 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed:nano33ble 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board libraries/Scheduler/examples/MultipleBlinks
flash		 % libraries/Scheduler/examples/MultipleBlinks
RAM for global variables		 % libraries/doom/examples/Doom
flash		 % libraries/doom/examples/Doom
RAM for global variables		 % libraries/KernelDebug/examples/KernelDebug
flash		 % libraries/KernelDebug/examples/KernelDebug
RAM for global variables		 % libraries/Portenta_SDCARD/examples/TestSDCARD
flash		 % libraries/Portenta_SDCARD/examples/TestSDCARD
RAM for global variables		 % libraries/Portenta_Video/examples/Envie_video_coreboot
flash		 % libraries/Portenta_Video/examples/Envie_video_coreboot
RAM for global variables		 % libraries/Portenta_System/examples/PortentaH7_getBootloaderInfo
flash		 % libraries/Portenta_System/examples/PortentaH7_getBootloaderInfo
RAM for global variables		 % libraries/Portenta_System/examples/PortentaH7_updateBootloader
flash		 % libraries/Portenta_System/examples/PortentaH7_updateBootloader
RAM for global variables		 % libraries/ThreadDebug/examples/ThreadDebug
flash		 % libraries/ThreadDebug/examples/ThreadDebug
RAM for global variables		 % libraries/USBHOST/examples/KeyboardController
flash		 % libraries/USBHOST/examples/KeyboardController
RAM for global variables		 % libraries/USBHOST/examples/Shell
flash		 % libraries/USBHOST/examples/Shell
RAM for global variables		 % libraries/WiFi/examples/PortentaWiFiFirmwareUpdater
flash		 % libraries/WiFi/examples/PortentaWiFiFirmwareUpdater
RAM for global variables		 % libraries/PDM/examples/PDMSerialPlotter
flash		 % libraries/PDM/examples/PDMSerialPlotter
RAM for global variables		 %
arduino:mbed:envie_m4 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed:envie_m7 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed:nano33ble 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,libraries/Scheduler/examples/MultipleBlinks<br>flash,%,libraries/Scheduler/examples/MultipleBlinks<br>RAM for global variables,%,libraries/doom/examples/Doom<br>flash,%,libraries/doom/examples/Doom<br>RAM for global variables,%,libraries/KernelDebug/examples/KernelDebug<br>flash,%,libraries/KernelDebug/examples/KernelDebug<br>RAM for global variables,%,libraries/Portenta_SDCARD/examples/TestSDCARD<br>flash,%,libraries/Portenta_SDCARD/examples/TestSDCARD<br>RAM for global variables,%,libraries/Portenta_Video/examples/Envie_video_coreboot<br>flash,%,libraries/Portenta_Video/examples/Envie_video_coreboot<br>RAM for global variables,%,libraries/Portenta_System/examples/PortentaH7_getBootloaderInfo<br>flash,%,libraries/Portenta_System/examples/PortentaH7_getBootloaderInfo<br>RAM for global variables,%,libraries/Portenta_System/examples/PortentaH7_updateBootloader<br>flash,%,libraries/Portenta_System/examples/PortentaH7_updateBootloader<br>RAM for global variables,%,libraries/ThreadDebug/examples/ThreadDebug<br>flash,%,libraries/ThreadDebug/examples/ThreadDebug<br>RAM for global variables,%,libraries/USBHOST/examples/KeyboardController<br>flash,%,libraries/USBHOST/examples/KeyboardController<br>RAM for global variables,%,libraries/USBHOST/examples/Shell<br>flash,%,libraries/USBHOST/examples/Shell<br>RAM for global variables,%,libraries/WiFi/examples/PortentaWiFiFirmwareUpdater<br>flash,%,libraries/WiFi/examples/PortentaWiFiFirmwareUpdater<br>RAM for global variables,%,libraries/PDM/examples/PDMSerialPlotter<br>flash,%,libraries/PDM/examples/PDMSerialPlotter<br>RAM for global variables,%
arduino:mbed:envie_m4,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed:envie_m7,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed:nano33ble,0,0.0,0,0.0,,,,,,,,,,,,,,,,,,,,,,,,,0,0.0,0,0.0,,,,,,,,,,,,,0,0.0,0,0.0

@iabdalkader
Copy link
Contributor

You might want to add a timeout in the pde.

@sebromero
Copy link
Collaborator Author

You might want to add a timeout in the pde.

@iabdalkader Can you elaborate? Timeout for what condition?

@iabdalkader
Copy link
Contributor

@sebromero If the sketch misses even a single byte, the cam and the sketch will deadlock. Adding a 1 second ? timeout in the pde may allow it to recover from that without restarting the sketch. Just a suggestion but otherwise it looks good.

@github-actions
Copy link

Memory usage change @ ee49989

Board flash % RAM for global variables %
arduino:mbed:envie_m4 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed:envie_m7 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed:nano33ble 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board libraries/Scheduler/examples/MultipleBlinks
flash		 % libraries/Scheduler/examples/MultipleBlinks
RAM for global variables		 % libraries/doom/examples/Doom
flash		 % libraries/doom/examples/Doom
RAM for global variables		 % libraries/KernelDebug/examples/KernelDebug
flash		 % libraries/KernelDebug/examples/KernelDebug
RAM for global variables		 % libraries/Portenta_SDCARD/examples/TestSDCARD
flash		 % libraries/Portenta_SDCARD/examples/TestSDCARD
RAM for global variables		 % libraries/Portenta_Video/examples/Envie_video_coreboot
flash		 % libraries/Portenta_Video/examples/Envie_video_coreboot
RAM for global variables		 % libraries/Portenta_System/examples/PortentaH7_getBootloaderInfo
flash		 % libraries/Portenta_System/examples/PortentaH7_getBootloaderInfo
RAM for global variables		 % libraries/Portenta_System/examples/PortentaH7_updateBootloader
flash		 % libraries/Portenta_System/examples/PortentaH7_updateBootloader
RAM for global variables		 % libraries/ThreadDebug/examples/ThreadDebug
flash		 % libraries/ThreadDebug/examples/ThreadDebug
RAM for global variables		 % libraries/USBHOST/examples/KeyboardController
flash		 % libraries/USBHOST/examples/KeyboardController
RAM for global variables		 % libraries/USBHOST/examples/Shell
flash		 % libraries/USBHOST/examples/Shell
RAM for global variables		 % libraries/WiFi/examples/PortentaWiFiFirmwareUpdater
flash		 % libraries/WiFi/examples/PortentaWiFiFirmwareUpdater
RAM for global variables		 % libraries/PDM/examples/PDMSerialPlotter
flash		 % libraries/PDM/examples/PDMSerialPlotter
RAM for global variables		 %
arduino:mbed:envie_m4 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed:envie_m7 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed:nano33ble 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,libraries/Scheduler/examples/MultipleBlinks<br>flash,%,libraries/Scheduler/examples/MultipleBlinks<br>RAM for global variables,%,libraries/doom/examples/Doom<br>flash,%,libraries/doom/examples/Doom<br>RAM for global variables,%,libraries/KernelDebug/examples/KernelDebug<br>flash,%,libraries/KernelDebug/examples/KernelDebug<br>RAM for global variables,%,libraries/Portenta_SDCARD/examples/TestSDCARD<br>flash,%,libraries/Portenta_SDCARD/examples/TestSDCARD<br>RAM for global variables,%,libraries/Portenta_Video/examples/Envie_video_coreboot<br>flash,%,libraries/Portenta_Video/examples/Envie_video_coreboot<br>RAM for global variables,%,libraries/Portenta_System/examples/PortentaH7_getBootloaderInfo<br>flash,%,libraries/Portenta_System/examples/PortentaH7_getBootloaderInfo<br>RAM for global variables,%,libraries/Portenta_System/examples/PortentaH7_updateBootloader<br>flash,%,libraries/Portenta_System/examples/PortentaH7_updateBootloader<br>RAM for global variables,%,libraries/ThreadDebug/examples/ThreadDebug<br>flash,%,libraries/ThreadDebug/examples/ThreadDebug<br>RAM for global variables,%,libraries/USBHOST/examples/KeyboardController<br>flash,%,libraries/USBHOST/examples/KeyboardController<br>RAM for global variables,%,libraries/USBHOST/examples/Shell<br>flash,%,libraries/USBHOST/examples/Shell<br>RAM for global variables,%,libraries/WiFi/examples/PortentaWiFiFirmwareUpdater<br>flash,%,libraries/WiFi/examples/PortentaWiFiFirmwareUpdater<br>RAM for global variables,%,libraries/PDM/examples/PDMSerialPlotter<br>flash,%,libraries/PDM/examples/PDMSerialPlotter<br>RAM for global variables,%
arduino:mbed:envie_m4,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed:envie_m7,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed:nano33ble,0,0.0,0,0.0,,,,,,,,,,,,,,,,,,,,,,,,,0,0.0,0,0.0,,,,,,,,,,,,,0,0.0,0,0.0

@sebromero
Copy link
Collaborator Author

@iabdalkader Makes sense. Added it 👍

@github-actions
Copy link

Memory usage change @ bf30ea8

Board flash % RAM for global variables %
arduino:mbed:envie_m4 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed:envie_m7 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed:nano33ble 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board libraries/Scheduler/examples/MultipleBlinks
flash		 % libraries/Scheduler/examples/MultipleBlinks
RAM for global variables		 % libraries/doom/examples/Doom
flash		 % libraries/doom/examples/Doom
RAM for global variables		 % libraries/KernelDebug/examples/KernelDebug
flash		 % libraries/KernelDebug/examples/KernelDebug
RAM for global variables		 % libraries/Portenta_SDCARD/examples/TestSDCARD
flash		 % libraries/Portenta_SDCARD/examples/TestSDCARD
RAM for global variables		 % libraries/Portenta_Video/examples/Envie_video_coreboot
flash		 % libraries/Portenta_Video/examples/Envie_video_coreboot
RAM for global variables		 % libraries/Portenta_System/examples/PortentaH7_getBootloaderInfo
flash		 % libraries/Portenta_System/examples/PortentaH7_getBootloaderInfo
RAM for global variables		 % libraries/Portenta_System/examples/PortentaH7_updateBootloader
flash		 % libraries/Portenta_System/examples/PortentaH7_updateBootloader
RAM for global variables		 % libraries/ThreadDebug/examples/ThreadDebug
flash		 % libraries/ThreadDebug/examples/ThreadDebug
RAM for global variables		 % libraries/USBHOST/examples/KeyboardController
flash		 % libraries/USBHOST/examples/KeyboardController
RAM for global variables		 % libraries/USBHOST/examples/Shell
flash		 % libraries/USBHOST/examples/Shell
RAM for global variables		 % libraries/WiFi/examples/PortentaWiFiFirmwareUpdater
flash		 % libraries/WiFi/examples/PortentaWiFiFirmwareUpdater
RAM for global variables		 % libraries/PDM/examples/PDMSerialPlotter
flash		 % libraries/PDM/examples/PDMSerialPlotter
RAM for global variables		 %
arduino:mbed:envie_m4 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed:envie_m7 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed:nano33ble 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,libraries/Scheduler/examples/MultipleBlinks<br>flash,%,libraries/Scheduler/examples/MultipleBlinks<br>RAM for global variables,%,libraries/doom/examples/Doom<br>flash,%,libraries/doom/examples/Doom<br>RAM for global variables,%,libraries/KernelDebug/examples/KernelDebug<br>flash,%,libraries/KernelDebug/examples/KernelDebug<br>RAM for global variables,%,libraries/Portenta_SDCARD/examples/TestSDCARD<br>flash,%,libraries/Portenta_SDCARD/examples/TestSDCARD<br>RAM for global variables,%,libraries/Portenta_Video/examples/Envie_video_coreboot<br>flash,%,libraries/Portenta_Video/examples/Envie_video_coreboot<br>RAM for global variables,%,libraries/Portenta_System/examples/PortentaH7_getBootloaderInfo<br>flash,%,libraries/Portenta_System/examples/PortentaH7_getBootloaderInfo<br>RAM for global variables,%,libraries/Portenta_System/examples/PortentaH7_updateBootloader<br>flash,%,libraries/Portenta_System/examples/PortentaH7_updateBootloader<br>RAM for global variables,%,libraries/ThreadDebug/examples/ThreadDebug<br>flash,%,libraries/ThreadDebug/examples/ThreadDebug<br>RAM for global variables,%,libraries/USBHOST/examples/KeyboardController<br>flash,%,libraries/USBHOST/examples/KeyboardController<br>RAM for global variables,%,libraries/USBHOST/examples/Shell<br>flash,%,libraries/USBHOST/examples/Shell<br>RAM for global variables,%,libraries/WiFi/examples/PortentaWiFiFirmwareUpdater<br>flash,%,libraries/WiFi/examples/PortentaWiFiFirmwareUpdater<br>RAM for global variables,%,libraries/PDM/examples/PDMSerialPlotter<br>flash,%,libraries/PDM/examples/PDMSerialPlotter<br>RAM for global variables,%
arduino:mbed:envie_m4,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed:envie_m7,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed:nano33ble,0,0.0,0,0.0,,,,,,,,,,,,,,,,,,,,,,,,,0,0.0,0,0.0,,,,,,,,,,,,,0,0.0,0,0.0

@github-actions
Copy link

Memory usage change @ da37f87

Board flash % RAM for global variables %
arduino:mbed:envie_m4 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed:envie_m7 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed:nano33ble 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board libraries/Scheduler/examples/MultipleBlinks
flash		 % libraries/Scheduler/examples/MultipleBlinks
RAM for global variables		 % libraries/doom/examples/Doom
flash		 % libraries/doom/examples/Doom
RAM for global variables		 % libraries/KernelDebug/examples/KernelDebug
flash		 % libraries/KernelDebug/examples/KernelDebug
RAM for global variables		 % libraries/Portenta_SDCARD/examples/TestSDCARD
flash		 % libraries/Portenta_SDCARD/examples/TestSDCARD
RAM for global variables		 % libraries/Portenta_Video/examples/Envie_video_coreboot
flash		 % libraries/Portenta_Video/examples/Envie_video_coreboot
RAM for global variables		 % libraries/Portenta_System/examples/PortentaH7_getBootloaderInfo
flash		 % libraries/Portenta_System/examples/PortentaH7_getBootloaderInfo
RAM for global variables		 % libraries/Portenta_System/examples/PortentaH7_updateBootloader
flash		 % libraries/Portenta_System/examples/PortentaH7_updateBootloader
RAM for global variables		 % libraries/ThreadDebug/examples/ThreadDebug
flash		 % libraries/ThreadDebug/examples/ThreadDebug
RAM for global variables		 % libraries/USBHOST/examples/KeyboardController
flash		 % libraries/USBHOST/examples/KeyboardController
RAM for global variables		 % libraries/USBHOST/examples/Shell
flash		 % libraries/USBHOST/examples/Shell
RAM for global variables		 % libraries/WiFi/examples/PortentaWiFiFirmwareUpdater
flash		 % libraries/WiFi/examples/PortentaWiFiFirmwareUpdater
RAM for global variables		 % libraries/PDM/examples/PDMSerialPlotter
flash		 % libraries/PDM/examples/PDMSerialPlotter
RAM for global variables		 %
arduino:mbed:envie_m4 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed:envie_m7 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed:nano33ble 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV 
Board,libraries/Scheduler/examples/MultipleBlinks<br>flash,%,libraries/Scheduler/examples/MultipleBlinks<br>RAM for global variables,%,libraries/doom/examples/Doom<br>flash,%,libraries/doom/examples/Doom<br>RAM for global variables,%,libraries/KernelDebug/examples/KernelDebug<br>flash,%,libraries/KernelDebug/examples/KernelDebug<br>RAM for global variables,%,libraries/Portenta_SDCARD/examples/TestSDCARD<br>flash,%,libraries/Portenta_SDCARD/examples/TestSDCARD<br>RAM for global variables,%,libraries/Portenta_Video/examples/Envie_video_coreboot<br>flash,%,libraries/Portenta_Video/examples/Envie_video_coreboot<br>RAM for global variables,%,libraries/Portenta_System/examples/PortentaH7_getBootloaderInfo<br>flash,%,libraries/Portenta_System/examples/PortentaH7_getBootloaderInfo<br>RAM for global variables,%,libraries/Portenta_System/examples/PortentaH7_updateBootloader<br>flash,%,libraries/Portenta_System/examples/PortentaH7_updateBootloader<br>RAM for global variables,%,libraries/ThreadDebug/examples/ThreadDebug<br>flash,%,libraries/ThreadDebug/examples/ThreadDebug<br>RAM for global variables,%,libraries/USBHOST/examples/KeyboardController<br>flash,%,libraries/USBHOST/examples/KeyboardController<br>RAM for global variables,%,libraries/USBHOST/examples/Shell<br>flash,%,libraries/USBHOST/examples/Shell<br>RAM for global variables,%,libraries/WiFi/examples/PortentaWiFiFirmwareUpdater<br>flash,%,libraries/WiFi/examples/PortentaWiFiFirmwareUpdater<br>RAM for global variables,%,libraries/PDM/examples/PDMSerialPlotter<br>flash,%,libraries/PDM/examples/PDMSerialPlotter<br>RAM for global variables,%
arduino:mbed:envie_m4,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed:envie_m7,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:mbed:nano33ble,0,0.0,0,0.0,,,,,,,,,,,,,,,,,,,,,,,,,0,0.0,0,0.0,,,,,,,,,,,,,0,0.0,0,0.0

@facchinm facchinm merged commit 66f1f03 into arduino:master Feb 23, 2021
@sebromero sebromero deleted the camera-example branch February 24, 2021 08:43
@sebromero sebromero mentioned this pull request Mar 18, 2021
Closed
@gargoyle777
Copy link

i'm still having the exact same problem. i'm using the last released exemple by the way.

@facchinm facchinm mentioned this pull request Oct 4, 2022
Open
@aliphys aliphys mentioned this pull request Apr 11, 2023
Open
@aliphys aliphys mentioned this pull request May 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facchinm facchinm facchinm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebromero @iabdalkader @gargoyle777 @facchinm