Skip to content
This repository was archived by the owner on Apr 16, 2021. It is now read-only.

Fix for #7 and #9 #10

Closed
wants to merge 2 commits into from
Closed

Fix for #7 and #9 #10

wants to merge 2 commits into from

Conversation

ohazi
Copy link

@ohazi ohazi commented Sep 5, 2019

Fixes #7 and #9.

I just noticed that my libmbed.a is 57MB, while the current one is 17MB. The archive and object formats look the same, and there don't appear to be a lot of new object files -- many of the existing ones are just bigger.

ARMmbed/mbed-os@79c7fa1

- Set GPIOTE_CONFIG_NUM_OF_LOW_POWER_EVENTS and
NRFX_GPIOTE_CONFIG_NUM_OF_LOW_POWER_EVENTS to 8 to allow more pin
interrupt sources. This addresses
arduino#7
- Cherry pick manual edits to cores/arduino/mbed/ after running
mbed-os-to-arduino script.
@ohazi
Copy link
Author

ohazi commented Sep 5, 2019

Instructions for the #7 workaround are here: #7 (comment)

Feel free to recreate the fix if you'd rather base it off of a different mbed-os release.

@facchinm
Copy link
Member

facchinm commented Sep 9, 2019

Hi @ohazi ,
sorry for the delay but I'm just back from vacation 🙂
I have a branch already rebased on mbed-5.14 with a couple of patches applied over it (the most notable one is the revert of ARMmbed/mbed-os@4e992cd to shrink the library size).
Since now all the other patches are merged in mbed's master I'm going to update the procedure and release the fixes during this week.
Thanks for your effort anyway! Any feedback on build scripts and how to improve them is very appreciated (PRs too of course 😉 )

@ohazi
Copy link
Author

ohazi commented Sep 9, 2019

No worries :-) This is a trivial enough fix that it probably makes more sense for you to apply it directly rather than forcing this PR onto whatever you're currently working on.

I think the main thing that confused me was all of the references to "mbed-os-5.4.0-rc1" in the last few months of "Update mbed to ..." commits. The build script worked a lot better once I realized I should be using master or 5.13 / 5.14, and after I found the last few manual edits in cores/arduino/mbed.

What was the story around 5.4.0-rc1?
(Edit: Oh, I see your comment now. de97082#commitcomment-35003971 Ha.)

@facchinm
Copy link
Member

Hi @ohazi , both #7 and #9 should be solved in master and 1.1.2 . I'm going to close the issues and this PR.
I rebased everything on 5.14.0-rc1 with these patches , will update the documentation accordingly 😉
Thanks a lot for the heads up!

@facchinm facchinm closed this Sep 12, 2019
@ohazi
Copy link
Author

ohazi commented Sep 12, 2019

Confirmed that my test case for #7 compiles and works correctly under 1.1.2. Looks good!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only one pin interrupt supported
2 participants