Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: arduino/arduino-builder
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.6.1
Choose a base ref
...
head repository: arduino/arduino-builder
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 12 commits
  • 5 files changed
  • 2 contributors

Commits on Sep 24, 2021

  1. Add CI workflow to synchronize with shared repository labels

    On every push that changes relevant files, and periodically, configure the repository's issue and pull request labels
    according to the universal, shared, and local label configuration files.
    per1234 committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    b5a243f View commit details
    Browse the repository at this point in the history
  2. Merge pull request #370 from per1234/sync-labels

    Add CI workflow to synchronize with shared repository labels
    per1234 authored Sep 24, 2021
    Configuration menu
    Copy the full SHA
    cd52453 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2021

  1. Correct context key name in "Sync Labels" workflow

    Incorrect context key name resulted in impossible to satisfy conditional, meaning the dry run determination code was
    solely dependent on the check for whether the workflow was triggered from the default branch name.
    per1234 committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    92ba0ea View commit details
    Browse the repository at this point in the history
  2. Sync labels in write mode on schedule trigger

    In order to facilitate the testing and review of proposed changes to the repository label infrastructure, the
    "Sync Labels" template workflow does a dry run when triggered under conditions that indicate it would not be appropriate
    to make real changes to the repository's labels. The changes that would have resulted are printed to the log, but not
    actually made.
    
    One of the criteria used to determine "dry run" mode usage is whether the event occurred on the repository's default
    branch. A trigger on a development branch or for a pull request should not result in a change to the labels.
    It turns out that GitHub does not define a `github.event.repository.default_branch` context item when a workflow is
    triggered by a `schedule` event. This resulted in the workflow always running in "dry run" mode on a `schedule` trigger.
    Since `schedule` and `repository_dispatch` triggers are only permitted for the default branch, there is no need to check
    whether the event's ref matches the default branch and it is safe to always run in write mode on these events.
    per1234 committed Oct 12, 2021
    Configuration menu
    Copy the full SHA
    e8a80cb View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2021

  1. Merge pull request #371 from per1234/sync-labels-fix

    Fix bugs in dry run determination code for "Sync Labels" workflow
    per1234 authored Oct 13, 2021
    Configuration menu
    Copy the full SHA
    9f960ef View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2021

  1. Use major version ref of carlosperate/download-file-action

    The `carlosperate/download-file-action` action is used in the GitHub Actions workflows as a convenient way to download
    external resources.
    
    A major version ref has been added to that repository. It will always point to the latest release of the "1" major
    version series. This means it is no longer necessary to do a full pin of the action version in use as before.
    
    Use of the major version ref will cause the workflow to use a stable version of the action, while also benefiting from
    ongoing development to the action up until such time as a new major release of an action is made. At that time we would
    need to evaluate whether any changes to the workflow are required by the breaking change that triggered the major
    release before manually updating the major ref (e.g., uses: `carlosperate/download-file-action@v2`). I think this
    approach strikes the right balance between stability and maintainability for these workflows.
    per1234 authored Dec 20, 2021
    Configuration menu
    Copy the full SHA
    4a00e28 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2021

  1. Merge pull request #372 from per1234/bump-download-file-action

    Use major version ref of `carlosperate/download-file-action`
    per1234 authored Dec 21, 2021
    Configuration menu
    Copy the full SHA
    99ac98e View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2022

  1. Configuration menu
    Copy the full SHA
    9ca3fda View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    99a6800 View commit details
    Browse the repository at this point in the history
  3. Remove useless compile flag

    cmaglie committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    4d49227 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0662887 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7537ac1 View commit details
    Browse the repository at this point in the history
Loading