-
-
Notifications
You must be signed in to change notification settings - Fork 114
Comparing changes
Open a pull request
base repository: arduino/arduino-builder
base: f493dba
head repository: arduino/arduino-builder
compare: 7537ac1
- 14 commits
- 5 files changed
- 2 contributors
Commits on May 14, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 069a1c5 - Browse repository at this point
Copy the full SHA 069a1c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2cfd40 - Browse repository at this point
Copy the full SHA c2cfd40View commit details
Commits on Sep 24, 2021
-
Add CI workflow to synchronize with shared repository labels
On every push that changes relevant files, and periodically, configure the repository's issue and pull request labels according to the universal, shared, and local label configuration files.
Configuration menu - View commit details
-
Copy full SHA for b5a243f - Browse repository at this point
Copy the full SHA b5a243fView commit details -
Merge pull request #370 from per1234/sync-labels
Add CI workflow to synchronize with shared repository labels
Configuration menu - View commit details
-
Copy full SHA for cd52453 - Browse repository at this point
Copy the full SHA cd52453View commit details
Commits on Oct 12, 2021
-
Correct context key name in "Sync Labels" workflow
Incorrect context key name resulted in impossible to satisfy conditional, meaning the dry run determination code was solely dependent on the check for whether the workflow was triggered from the default branch name.
Configuration menu - View commit details
-
Copy full SHA for 92ba0ea - Browse repository at this point
Copy the full SHA 92ba0eaView commit details -
Sync labels in write mode on schedule trigger
In order to facilitate the testing and review of proposed changes to the repository label infrastructure, the "Sync Labels" template workflow does a dry run when triggered under conditions that indicate it would not be appropriate to make real changes to the repository's labels. The changes that would have resulted are printed to the log, but not actually made. One of the criteria used to determine "dry run" mode usage is whether the event occurred on the repository's default branch. A trigger on a development branch or for a pull request should not result in a change to the labels. It turns out that GitHub does not define a `github.event.repository.default_branch` context item when a workflow is triggered by a `schedule` event. This resulted in the workflow always running in "dry run" mode on a `schedule` trigger. Since `schedule` and `repository_dispatch` triggers are only permitted for the default branch, there is no need to check whether the event's ref matches the default branch and it is safe to always run in write mode on these events.
Configuration menu - View commit details
-
Copy full SHA for e8a80cb - Browse repository at this point
Copy the full SHA e8a80cbView commit details
Commits on Oct 13, 2021
-
Merge pull request #371 from per1234/sync-labels-fix
Fix bugs in dry run determination code for "Sync Labels" workflow
Configuration menu - View commit details
-
Copy full SHA for 9f960ef - Browse repository at this point
Copy the full SHA 9f960efView commit details
Commits on Dec 20, 2021
-
Use major version ref of
carlosperate/download-file-action
The `carlosperate/download-file-action` action is used in the GitHub Actions workflows as a convenient way to download external resources. A major version ref has been added to that repository. It will always point to the latest release of the "1" major version series. This means it is no longer necessary to do a full pin of the action version in use as before. Use of the major version ref will cause the workflow to use a stable version of the action, while also benefiting from ongoing development to the action up until such time as a new major release of an action is made. At that time we would need to evaluate whether any changes to the workflow are required by the breaking change that triggered the major release before manually updating the major ref (e.g., uses: `carlosperate/download-file-action@v2`). I think this approach strikes the right balance between stability and maintainability for these workflows.
Configuration menu - View commit details
-
Copy full SHA for 4a00e28 - Browse repository at this point
Copy the full SHA 4a00e28View commit details
Commits on Dec 21, 2021
-
Merge pull request #372 from per1234/bump-download-file-action
Use major version ref of `carlosperate/download-file-action`
Configuration menu - View commit details
-
Copy full SHA for 99ac98e - Browse repository at this point
Copy the full SHA 99ac98eView commit details
Commits on Jan 10, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 9ca3fda - Browse repository at this point
Copy the full SHA 9ca3fdaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 99a6800 - Browse repository at this point
Copy the full SHA 99a6800View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d49227 - Browse repository at this point
Copy the full SHA 4d49227View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0662887 - Browse repository at this point
Copy the full SHA 0662887View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7537ac1 - Browse repository at this point
Copy the full SHA 7537ac1View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff f493dba...7537ac1