Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: arduino/arduino-builder
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: arduino/arduino-builder
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: functionpointer
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 6 commits
  • 6 files changed
  • 2 contributors

Commits on Nov 5, 2015

  1. Comparing prototypes with original functions. If they don't match, 

    prototype is skipped

Signed-off-by: Federico Fissore <f.fissore@arduino.cc>
    Federico Fissore committed Nov 5, 2015
    Configuration menu
    Copy the full SHA
    9f371d2 View commit details
    Browse the repository at this point in the history

  2. Extracted function for readability 

    Signed-off-by: Federico Fissore <f.fissore@arduino.cc>
    Federico Fissore committed Nov 5, 2015
    Configuration menu
    Copy the full SHA
    830f8f2 View commit details
    Browse the repository at this point in the history

  3. Testing that prototype of a function containing a typename is not gen… 

    …erated

Signed-off-by: Federico Fissore <f.fissore@arduino.cc>
    Federico Fissore committed Nov 5, 2015
    Configuration menu
    Copy the full SHA
    bb83289 View commit details
    Browse the repository at this point in the history

  4. Be more conservative about what prototypes to add 

    Previously, a prototype was added if the generated prototype was
contained in the original source code line, to catch cases where ctags
did not provide enough information to generate a completely correct
prototype. However, this substring matching was still too liberal: if
something unsupported was present at the start of the function
definition (such as `static` in `static void func()`) the substring
matching would still think the prototype was correct, but the compiler
would complain.

This commit changes this to use prefix matching: Only if the original source
line starts with the generated prefix, a prototype is added. Ideally,
the full definition is matched, but that requires knowing where it ends,
which can be at a curly open, but also a comment start, etc., so better
to just leave it at this.

This means that inline functions and functions with attributes specified
at the start will no longer get a prototype, so the
TestPrototypesAdderSketchWithInlineFunction is modified accordingly.

Signed-off-by: Matthijs Kooijman <matthijs@stdin.nl>
    @matthijskooijman
    matthijskooijman authored and Federico Fissore committed Nov 5, 2015
    Configuration menu
    Copy the full SHA
    8bb7912 View commit details
    Browse the repository at this point in the history

  5. Merge some prototype generation testcases 

    All of these contain complex functions that should not get any
prototypes, so merging them into a single testcase seems useful.

Signed-off-by: Matthijs Kooijman <matthijs@stdin.nl>
    @matthijskooijman
    matthijskooijman authored and Federico Fissore committed Nov 5, 2015
    Configuration menu
    Copy the full SHA
    c531892 View commit details
    Browse the repository at this point in the history

  6. Add prototype adding test for static functions 

    Static functions should not get a prototype added, since ctags does not
allow generating the correct prototype.

Signed-off-by: Matthijs Kooijman <matthijs@stdin.nl>
    @matthijskooijman
    matthijskooijman authored and Federico Fissore committed Nov 5, 2015
    Configuration menu
    Copy the full SHA
    c128bfa View commit details
    Browse the repository at this point in the history
Loading