Use CPP recipe to generate PREPROC if empty #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, I don't really like fiddling around in the platform.txt entries from code like that, though I can't think of a better way just now. I thought you could perhaps just define a |
solves arduino#106 Signed-off-by: Martino Facchin <m.facchin@arduino.cc>
|
Merging this PR to let it stay in staging for some weeks, eventually reverting it if testers find any drawback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
preprocrule is nothing more than thecpprule with some extra flags and a different target, generate it instead than manually compiling a list of "compatibility_flags" and relying on itsolves #106
@matthijskooijman