Skip to content

Modularization of ctags and some refactorings #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 8, 2016
Merged

Modularization of ctags and some refactorings #87

merged 6 commits into from
Jan 8, 2016

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Dec 29, 2015

  • "ctags" is now a module and allows an easier exchange of "parsing engines"
  • added an explicit PropertiesMap type that simplify the use of map[string]string in most cases and
    remove redundant utility functions
  • other minor cleanups

/cc @matthijskooijman @facchinm

@cmaglie
Simplify CTag structure
3cad689 
Signed-off-by: Cristian Maglie <c.maglie@arduino.cc>
@cmaglie
Skip empty prototype generation
11efa53 
Signed-off-by: Cristian Maglie <c.maglie@arduino.cc>
@cmaglie
Moving ctags modules into their own package
583aab1 
The following files

   ctags_parser.go
   ctags_runner.go
   ctags_to_prototypes.go

have been moved into "ctags" package.

Signed-off-by: Cristian Maglie <c.maglie@arduino.cc>
@cmaglie
Introduce explicit PropertiesMap type
505cc4a 
This simplify the use of map[string]string in most cases and
remove redundant utility functions.

Signed-off-by: Cristian Maglie <c.maglie@arduino.cc>
@cmaglie
Moving check for signatureContainsDefaultArg to prototypes_adder
14e2351 
ctags should list all prototypes, this commit moves the responsibility of
prototypes selection to prototypes_adder

Signed-off-by: Cristian Maglie <c.maglie@arduino.cc>
@cmaglie
Some minor cosmetics
c205ecd 
Signed-off-by: Cristian Maglie <c.maglie@arduino.cc>
@cmaglie cmaglie self-assigned this Dec 29, 2015
@matthijskooijman
Copy link
Collaborator

Looks good to me!

@cmaglie cmaglie merged commit c205ecd into arduino:master Jan 8, 2016
@cmaglie cmaglie deleted the refactorings_part_1 branch January 8, 2016 17:05
@cmaglie cmaglie mentioned this pull request Apr 18, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cmaglie cmaglie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmaglie @matthijskooijman