Skip to content

As a gRPC consumer, I want the CLI to collects all the files composing a sketch #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kittaakos opened this issue Jul 17, 2020 · 0 comments · Fixed by #926
Closed

As a gRPC consumer, I want the CLI to collects all the files composing a sketch #837

kittaakos opened this issue Jul 17, 2020 · 0 comments · Fixed by #926
Labels
type: enhancement Proposed improvement

Comments

@kittaakos
Copy link
Contributor

It is already implemented by the CLI but it's not yet exposed as an API/command:

arduino-cli/arduino/builder/sketch.go

Lines 100 to 103 in fff99af

// SketchLoad collects all the files composing a sketch.
// The parameter `sketchPath` holds a path pointing to a single sketch file or a sketch folder,
// the path must be absolute.
func SketchLoad(sketchPath, buildPath string) (*sketch.Sketch, error) {

I would like to avoid duplicating code in the Pro IDE and fully rely on this CLI functionality.

Thank you!
@rsora rsora added the type: enhancement Proposed improvement label Jul 21, 2020
@rsora rsora changed the title [feature-request] As a gRPC consumer, I want the CLI to collects all the files composing a sketch As a gRPC consumer, I want the CLI to collects all the files composing a sketch Jul 21, 2020
@silvanocerza silvanocerza mentioned this issue Aug 26, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added gRPC interface to collect every sketch file arduino/arduino-cli
2 participants
@kittaakos @rsora