Fixed FIELD_LOWER_SNAKE_CASE lint warning

arduino · cmaglie · Mar 29, 2021 · Mar 15, 2021 · Mar 15, 2021 · Mar 15, 2021
commit 34e70b851168d37faa46a85cfbbeab6ff4a8cd29
diff --git a/cli/board/details.go b/cli/board/details.go
@@ -137,17 +137,17 @@ func (dr detailsResult) String() string {
 	for i, idp := range details.IdentificationPref {
 		if i == 0 {
 			t.AddRow() // get some space from above
-			t.AddRow(tr("Identification properties:"), "VID:"+idp.UsbID.VID+" PID:"+idp.UsbID.PID)
+			t.AddRow(tr("Identification properties:"), "VID:"+idp.UsbId.Vid+" PID:"+idp.UsbId.Pid)
 			continue
 		}
-		t.AddRow("", "VID:"+idp.UsbID.VID+" PID:"+idp.UsbID.PID)
+		t.AddRow("", "VID:"+idp.UsbId.Vid+" PID:"+idp.UsbId.Pid)
 	}
 
 	t.AddRow() // get some space from above
 	addIfNotEmpty(tr("Package name:"), details.Package.Name)
 	addIfNotEmpty(tr("Package maintainer:"), details.Package.Maintainer)
 	addIfNotEmpty(tr("Package URL:"), details.Package.Url)
-	addIfNotEmpty(tr("Package website:"), details.Package.WebsiteURL)
+	addIfNotEmpty(tr("Package website:"), details.Package.WebsiteUrl)
 	addIfNotEmpty(tr("Package online help:"), details.Package.Help.Online)
 
 	t.AddRow() // get some space from above

diff --git a/cli/board/list.go b/cli/board/list.go
@@ -147,15 +147,15 @@ func (dr result) String() string {
 		if boards := port.GetBoards(); len(boards) > 0 {
 			sort.Slice(boards, func(i, j int) bool {
 				x, y := boards[i], boards[j]
-				return x.GetName() < y.GetName() || (x.GetName() == y.GetName() && x.GetFQBN() < y.GetFQBN())
+				return x.GetName() < y.GetName() || (x.GetName() == y.GetName() && x.GetFqbn() < y.GetFqbn())
 			})
 			for _, b := range boards {
 				board := b.GetName()
 
 				// to improve the user experience, show on a dedicated column
 				// the name of the core supporting the board detected
 				var coreName = ""
-				fqbn, err := cores.ParseFQBN(b.GetFQBN())
+				fqbn, err := cores.ParseFQBN(b.GetFqbn())
 				if err == nil {
 					coreName = fmt.Sprintf("%s:%s", fqbn.Package, fqbn.PlatformArch)
 				}
@@ -206,15 +206,15 @@ func (dr watchEvent) String() string {
 	if boards := dr.Boards; len(boards) > 0 {
 		sort.Slice(boards, func(i, j int) bool {
 			x, y := boards[i], boards[j]
-			return x.GetName() < y.GetName() || (x.GetName() == y.GetName() && x.GetFQBN() < y.GetFQBN())
+			return x.GetName() < y.GetName() || (x.GetName() == y.GetName() && x.GetFqbn() < y.GetFqbn())
 		})
 		for _, b := range boards {
 			board := b.GetName()
 
 			// to improve the user experience, show on a dedicated column
 			// the name of the core supporting the board detected
 			var coreName = ""
-			fqbn, err := cores.ParseFQBN(b.GetFQBN())
+			fqbn, err := cores.ParseFQBN(b.GetFqbn())
 			if err == nil {
 				coreName = fmt.Sprintf("%s:%s", fqbn.Package, fqbn.PlatformArch)
 			}

diff --git a/cli/board/listall.go b/cli/board/listall.go
@@ -91,7 +91,7 @@ func (dr resultAll) String() string {
 		if item.IsHidden {
 			hidden = "(hidden)"
 		}
-		t.AddRow(item.GetName(), item.GetFQBN(), hidden)
+		t.AddRow(item.GetName(), item.GetFqbn(), hidden)
 	}
 	return t.Render()
 }
diff --git a/cli/board/search.go b/cli/board/search.go
@@ -93,7 +93,7 @@ func (r searchResults) String() string {
 		if item.IsHidden {
 			hidden = "(hidden)"
 		}
-		t.AddRow(item.GetName(), item.GetFQBN(), item.Platform.ID, hidden)
+		t.AddRow(item.GetName(), item.GetFqbn(), item.Platform.Id, hidden)
 	}
 	return t.Render()
 }
diff --git a/cli/core/list.go b/cli/core/list.go
@@ -88,10 +88,10 @@ func (ir installedResult) String() string {
 	t := table.New()
 	t.SetHeader("ID", "Installed", "Latest", "Name")
 	sort.Slice(ir.platforms, func(i, j int) bool {
-		return ir.platforms[i].ID < ir.platforms[j].ID
+		return ir.platforms[i].Id < ir.platforms[j].Id
 	})
 	for _, p := range ir.platforms {
-		t.AddRow(p.ID, p.Installed, p.Latest, p.Name)
+		t.AddRow(p.Id, p.Installed, p.Latest, p.Name)
 	}
 
 	return t.Render()

diff --git a/cli/core/search.go b/cli/core/search.go
@@ -98,10 +98,10 @@ func (sr searchResults) String() string {
 		t := table.New()
 		t.SetHeader("ID", "Version", "Name")
 		sort.Slice(sr.platforms, func(i, j int) bool {
-			return sr.platforms[i].ID < sr.platforms[j].ID
+			return sr.platforms[i].Id < sr.platforms[j].Id
 		})
 		for _, item := range sr.platforms {
-			t.AddRow(item.GetID(), item.GetLatest(), item.GetName())
+			t.AddRow(item.GetId(), item.GetLatest(), item.GetName())
 		}
 		return t.Render()
 	}

diff --git a/cli/core/upgrade.go b/cli/core/upgrade.go
@@ -72,7 +72,7 @@ func runUpgradeCommand(cmd *cobra.Command, args []string) {
 		}
 
 		for _, t := range targets {
-			args = append(args, t.ID)
+			args = append(args, t.Id)
 		}
 	}
 

diff --git a/commands/board/details.go b/commands/board/details.go
@@ -61,7 +61,7 @@ func Details(ctx context.Context, req *rpc.BoardDetailsRequest) (*rpc.BoardDetai
 	details.Package = &rpc.Package{
 		Name:       boardPackage.Name,
 		Maintainer: boardPackage.Maintainer,
-		WebsiteURL: boardPackage.WebsiteURL,
+		WebsiteUrl: boardPackage.WebsiteURL,
 		Email:      boardPackage.Email,
 		Help:       &rpc.Help{Online: boardPackage.Help.Online},
 		Url:        boardPackage.URL,
@@ -85,7 +85,7 @@ func Details(ctx context.Context, req *rpc.BoardDetailsRequest) (*rpc.BoardDetai
 	pids := board.Properties.SubTree("pid")
 	for id, vid := range vids.AsMap() {
 		if pid, ok := pids.GetOk(id); ok {
-			idPref := rpc.IdentificationPref{UsbID: &rpc.USBID{VID: vid, PID: pid}}
+			idPref := rpc.IdentificationPref{UsbId: &rpc.USBID{Vid: vid, Pid: pid}}
 			details.IdentificationPref = append(details.IdentificationPref, &idPref)
 		}
 	}

diff --git a/commands/board/list.go b/commands/board/list.go
@@ -88,9 +88,9 @@ func apiByVidPid(vid, pid string) ([]*rpc.BoardListItem, error) {
 
 		retVal = append(retVal, &rpc.BoardListItem{
 			Name: name,
-			FQBN: fqbn,
-			VID:  vid,
-			PID:  pid,
+			Fqbn: fqbn,
+			Vid:  vid,
+			Pid:  pid,
 		})
 	} else {
 		return nil, errors.Wrap(err, "error querying Arduino Cloud Api")
@@ -119,9 +119,9 @@ func identify(pm *packagemanager.PackageManager, port *commands.BoardPort) ([]*r
 	for _, board := range pm.IdentifyBoard(port.IdentificationPrefs) {
 		boards = append(boards, &rpc.BoardListItem{
 			Name: board.Name(),
-			FQBN: board.FQBN(),
-			VID:  port.IdentificationPrefs.Get("vid"),
-			PID:  port.IdentificationPrefs.Get("pid"),
+			Fqbn: board.FQBN(),
+			Vid:  port.IdentificationPrefs.Get("vid"),
+			Pid:  port.IdentificationPrefs.Get("pid"),
 		})
 	}
 

diff --git a/commands/board/list_test.go b/commands/board/list_test.go
@@ -52,9 +52,9 @@ func TestGetByVidPid(t *testing.T) {
 	require.Nil(t, err)
 	require.Len(t, res, 1)
 	require.Equal(t, "Arduino/Genuino MKR1000", res[0].Name)
-	require.Equal(t, "arduino:samd:mkr1000", res[0].FQBN)
-	require.Equal(t, "0xf420", res[0].VID)
-	require.Equal(t, "0XF069", res[0].PID)
+	require.Equal(t, "arduino:samd:mkr1000", res[0].Fqbn)
+	require.Equal(t, "0xf420", res[0].Vid)
+	require.Equal(t, "0XF069", res[0].Pid)
 
 	// wrong vid (too long), wrong pid (not an hex value)
 	res, err = apiByVidPid("0xfffff", "0xDEFG")

diff --git a/commands/board/listall.go b/commands/board/listall.go
@@ -75,7 +75,7 @@ func ListAll(ctx context.Context, req *rpc.BoardListAllRequest) (*rpc.BoardListA
 			}
 
 			rpcPlatform := &rpc.Platform{
-				ID:                platform.String(),
+				Id:                platform.String(),
 				Installed:         installedVersion,
 				Latest:            latestVersion,
 				Name:              platform.Name,
@@ -108,7 +108,7 @@ func ListAll(ctx context.Context, req *rpc.BoardListAllRequest) (*rpc.BoardListA
 
 				list.Boards = append(list.Boards, &rpc.BoardListItem{
 					Name:     board.Name(),
-					FQBN:     board.FQBN(),
+					Fqbn:     board.FQBN(),
 					IsHidden: board.IsHidden(),
 					Platform: rpcPlatform,
 				})

diff --git a/commands/board/search.go b/commands/board/search.go
@@ -68,7 +68,7 @@ func Search(ctx context.Context, req *rpc.BoardSearchRequest) (*rpc.BoardSearchR
 			}
 
 			rpcPlatform := &rpc.Platform{
-				ID:                platform.String(),
+				Id:                platform.String(),
 				Installed:         installedVersion,
 				Latest:            latestPlatformRelease.Version.String(),
 				Name:              platform.Name,
@@ -98,7 +98,7 @@ func Search(ctx context.Context, req *rpc.BoardSearchRequest) (*rpc.BoardSearchR
 
 					res.Boards = append(res.Boards, &rpc.BoardListItem{
 						Name:     board.Name(),
-						FQBN:     board.FQBN(),
+						Fqbn:     board.FQBN(),
 						IsHidden: board.IsHidden(),
 						Platform: rpcPlatform,
 					})

diff --git a/commands/core.go b/commands/core.go
@@ -51,7 +51,7 @@ func PlatformReleaseToRPC(platformRelease *cores.PlatformRelease) *rpc.Platform
 	}
 
 	result := &rpc.Platform{
-		ID:                platformRelease.Platform.String(),
+		Id:                platformRelease.Platform.String(),
 		Name:              platformRelease.Platform.Name,
 		Maintainer:        platformRelease.Platform.Package.Maintainer,
 		Website:           platformRelease.Platform.Package.WebsiteURL,

diff --git a/commands/core/search_test.go b/commands/core/search_test.go
@@ -55,7 +55,7 @@ func TestPlatformSearch(t *testing.T) {
 
 	require.Len(t, res.SearchOutput, 2)
 	require.Contains(t, res.SearchOutput, &commands.Platform{
-		ID:         "Retrokits-RK002:arm",
+		Id:         "Retrokits-RK002:arm",
 		Installed:  "",
 		Latest:     "1.0.5",
 		Name:       "RK002",
@@ -65,7 +65,7 @@ func TestPlatformSearch(t *testing.T) {
 		Boards:     []*commands.Board{{Name: "RK002"}},
 	})
 	require.Contains(t, res.SearchOutput, &commands.Platform{
-		ID:         "Retrokits-RK002:arm",
+		Id:         "Retrokits-RK002:arm",
 		Installed:  "",
 		Latest:     "1.0.6",
 		Name:       "RK002",
@@ -84,7 +84,7 @@ func TestPlatformSearch(t *testing.T) {
 	require.NotNil(t, res)
 	require.Len(t, res.SearchOutput, 1)
 	require.Contains(t, res.SearchOutput, &commands.Platform{
-		ID:         "Retrokits-RK002:arm",
+		Id:         "Retrokits-RK002:arm",
 		Installed:  "",
 		Latest:     "1.0.6",
 		Name:       "RK002",
@@ -104,7 +104,7 @@ func TestPlatformSearch(t *testing.T) {
 	require.NotNil(t, res)
 	require.Len(t, res.SearchOutput, 2)
 	require.Contains(t, res.SearchOutput, &commands.Platform{
-		ID:         "Retrokits-RK002:arm",
+		Id:         "Retrokits-RK002:arm",
 		Installed:  "",
 		Latest:     "1.0.5",
 		Name:       "RK002",
@@ -114,7 +114,7 @@ func TestPlatformSearch(t *testing.T) {
 		Boards:     []*commands.Board{{Name: "RK002"}},
 	})
 	require.Contains(t, res.SearchOutput, &commands.Platform{
-		ID:         "Retrokits-RK002:arm",
+		Id:         "Retrokits-RK002:arm",
 		Installed:  "",
 		Latest:     "1.0.6",
 		Name:       "RK002",
@@ -134,7 +134,7 @@ func TestPlatformSearch(t *testing.T) {
 	require.NotNil(t, res)
 	require.Len(t, res.SearchOutput, 2)
 	require.Contains(t, res.SearchOutput, &commands.Platform{
-		ID:         "Retrokits-RK002:arm",
+		Id:         "Retrokits-RK002:arm",
 		Installed:  "",
 		Latest:     "1.0.5",
 		Name:       "RK002",
@@ -144,7 +144,7 @@ func TestPlatformSearch(t *testing.T) {
 		Boards:     []*commands.Board{{Name: "RK002"}},
 	})
 	require.Contains(t, res.SearchOutput, &commands.Platform{
-		ID:         "Retrokits-RK002:arm",
+		Id:         "Retrokits-RK002:arm",
 		Installed:  "",
 		Latest:     "1.0.6",
 		Name:       "RK002",
@@ -164,7 +164,7 @@ func TestPlatformSearch(t *testing.T) {
 	require.NotNil(t, res)
 	require.Len(t, res.SearchOutput, 2)
 	require.Contains(t, res.SearchOutput, &commands.Platform{
-		ID:         "Retrokits-RK002:arm",
+		Id:         "Retrokits-RK002:arm",
 		Installed:  "",
 		Latest:     "1.0.5",
 		Name:       "RK002",
@@ -174,7 +174,7 @@ func TestPlatformSearch(t *testing.T) {
 		Boards:     []*commands.Board{{Name: "RK002"}},
 	})
 	require.Contains(t, res.SearchOutput, &commands.Platform{
-		ID:         "Retrokits-RK002:arm",
+		Id:         "Retrokits-RK002:arm",
 		Installed:  "",
 		Latest:     "1.0.6",
 		Name:       "RK002",
@@ -194,7 +194,7 @@ func TestPlatformSearch(t *testing.T) {
 	require.NotNil(t, res)
 	require.Len(t, res.SearchOutput, 1)
 	require.Contains(t, res.SearchOutput, &commands.Platform{
-		ID:         "arduino:avr",
+		Id:         "arduino:avr",
 		Installed:  "",
 		Latest:     "1.8.3",
 		Name:       "Arduino AVR Boards",
@@ -240,7 +240,7 @@ func TestPlatformSearch(t *testing.T) {
 	require.NotNil(t, res)
 	require.Len(t, res.SearchOutput, 1)
 	require.Contains(t, res.SearchOutput, &commands.Platform{
-		ID:         "arduino:avr",
+		Id:         "arduino:avr",
 		Installed:  "",
 		Latest:     "1.8.3",
 		Name:       "Arduino AVR Boards",

diff --git a/commands/daemon/monitor.go b/commands/daemon/monitor.go
@@ -38,7 +38,7 @@ func (s *MonitorService) StreamingOpen(stream rpc.MonitorService_StreamingOpenSe
 	}
 
 	// ensure it's a config message and not data
-	config := msg.GetMonitorConfig()
+	config := msg.GetConfig()
 	if config == nil {
 		return errors.New("first message must contain monitor configuration, not data")
 	}

diff --git a/rpc/buf.yaml b/rpc/buf.yaml
@@ -4,16 +4,6 @@ lint:
     ENUM_ZERO_VALUE_SUFFIX:
       - commands/lib.proto
       - monitor/monitor.proto
-    FIELD_LOWER_SNAKE_CASE:
-      - commands/board.proto
-      - commands/commands.proto
-      - commands/common.proto
-      - commands/compile.proto
-      - commands/core.proto
-      - commands/lib.proto
-      - debug/debug.proto
-      - monitor/monitor.proto
-      - settings/settings.proto
     PACKAGE_DIRECTORY_MATCH:
       - commands/board.proto
       - commands/commands.proto
-Original file line number
+Diff line change
@@ Expand Up / @@ -72,7 +72,7 @@ func runUpgradeCommand(cmd *cobra.Command, args []string) { @@
     		}
     		for _, t := range targets {
-    			args = append(args, t.ID)
+    			args = append(args, t.Id)
     		}
     	}
@@ Expand Down @@