Skip to content

[skip-changelog] Migrate tests from test_completion.py to completion_test.go #1844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 2, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Migrated TestCompletionBashNoDesc from test_completion.py to completi…
…on_test.go
  • Loading branch information
MatteoPologruto committed Aug 29, 2022
commit d2c93a6929e8b88d5c6c20ff2c06fd42581f6003
12 changes: 12 additions & 0 deletions internal/integrationtest/completion/completion_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,3 +76,15 @@ func TestCompletionPowershell(t *testing.T) {
require.Contains(t, string(stdout), "# powershell completion for arduino-cli")
require.Contains(t, string(stdout), "Register-ArgumentCompleter -CommandName 'arduino-cli' -ScriptBlock")
}

func TestCompletionBashNoDesc(t *testing.T) {
env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
defer env.CleanUp()

stdout, stderr, err := cli.Run("completion", "bash", "--no-descriptions")
require.NoError(t, err)
require.Empty(t, stderr)
require.Contains(t, string(stdout), "# bash completion V2 for arduino-cli")
require.Contains(t, string(stdout), "__start_arduino-cli()")
require.Contains(t, string(stdout), "__completeNoDesc")
}
9 changes: 0 additions & 9 deletions test/test_completion.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,6 @@
# a commercial license, send an email to license@arduino.cc.


def test_completion_bash_no_desc(run_command):
result = run_command(["completion", "bash", "--no-descriptions"])
assert result.ok
assert result.stderr == ""
assert "# bash completion V2 for arduino-cli" in result.stdout
assert "__start_arduino-cli()" in result.stdout
assert "__completeNoDesc" in result.stdout


def test_completion_zsh_no_desc(run_command):
result = run_command(["completion", "zsh", "--no-descriptions"])
assert result.ok
Expand Down