Add Delete command to gRPC #2212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #2212 +/- ##
==========================================
+ Coverage 62.95% 62.99% +0.03%
==========================================
Files 220 220
Lines 19478 19496 +18
==========================================
+ Hits 12263 12281 +18
Misses 6132 6132
Partials 1083 1083
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
3 tasks
cmaglie
reviewed
Jun 14, 2023
cmaglie
reviewed
Jun 14, 2023
d57d41f to
6ade5da
Compare
6ade5da to
d74352b
Compare
d74352b to
9ae9461
Compare
cmaglie
approved these changes
Jun 27, 2023
3 tasks
Closed
3 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
Code enhancement
What is the current behavior?
It is not possible to entirely remove a key from the config file using the gRPC interface. Setting it to an empty object using either
MergeorSetValuewould not work because viper would set it back to its default value, which is the one written in the config when it was loaded.The only workaround would be to set the nested key to empty objects using the above mentioned commands:
What is the new behavior?
The key can be deleted from the runtime configuration using the
Deletecommand.Does this PR introduce a breaking change, and is titled accordingly?
No