Skip to content

feature: Added gRPC close signal to Monitor call (allows graceful close of monitor) #2276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 2, 2024
+572 −181
Merged

feature: Added gRPC close signal to Monitor call (allows graceful close of monitor) #2276

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bf067ea
Refactored gRPC Monitor API
cmaglie Aug 21, 2023
9c59c34
Added Close request to gRPC Monitor API
cmaglie Aug 21, 2023
86cb04f
Updated docs
cmaglie Aug 23, 2023
5a39d1c
Made CreateEnvForDaeamon available in all integration tests
cmaglie Oct 25, 2023
62f3f1b
Added integration test
cmaglie Oct 25, 2023
2cf3f8f
lint: avoid redefinition of the built-in function close
cmaglie Oct 25, 2023
3fd0bad
lint: comparing with == will fail on wrapped errors. Use errors.Is to…
cmaglie Oct 25, 2023
f2a023a
Allow up to 5 seconds for a pluggable monitor to gracefully close
cmaglie Oct 26, 2023
094e3a5
Made the gRPC daemon actually wait for port close completion
cmaglie Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint: avoid redefinition of the built-in function close
  • Loading branch information
@cmaglie
cmaglie committed Jan 2, 2024
commit 2cf3f8f7d894b0b51a25fcf2ba3e60cba6caff7b
2 changes: 1 addition & 1 deletion commands/daemon/daemon.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,7 @@ func (s *ArduinoCoreServerImpl) Monitor(stream rpc.ArduinoCoreService_MonitorSer
}
}
}
if close := msg.GetClose(); close {
if closeMsg := msg.GetClose(); closeMsg {
if err := portProxy.Close(); err != nil {
logrus.WithError(err).Debug("Error closing monitor port")
}
Expand Down