ctags: filterSketchSource: enlarge buffer size to handle long lines #2935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes arduino/ArduinoCore-zephyr#140
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)configuration.schema.jsonupdated if new parameters are added.What kind of change does this PR introduce?
When parsing the preprocessed file, only the lines relevant for the sketch are preserved.
However, golang's
scannerfails if a line is too long for its buffer.Overcome the issue by adding a 1MB buffer (extremely conservative) and a non-fatal error message in case it's still not enough.
What is the current behavior?
Compiling any sketch from https://github.com/arduino/ArduinoCore-zephyr fails to create prototypes due to
analogPinsmacro, which expands into a ~90K characters lineWhat is the new behavior?
The prototypes are created correctly
Does this PR introduce a breaking change, and is titled accordingly?
No breaking change
Other information