Skip to content

Add unit and integration testing for the sketch recursive load functionality #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 30, 2019
Merged

Add unit and integration testing for the sketch recursive load functionality #462

merged 6 commits into from
Oct 30, 2019

Conversation

rsora
Copy link
Contributor

@rsora rsora commented Oct 29, 2019

This PR adds testing to PR #421 : a sketch loading feature that supports symlinks.

The tests cover the following:

masci
masci suggested changes Oct 30, 2019
View reviewed changes
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just nits, it LGTM otherwise

@rsora rsora merged commit 292277f into master Oct 30, 2019
@rsora rsora deleted the rsora/walk-test branch October 30, 2019 15:22
@silvanocerza silvanocerza mentioned this pull request Jul 9, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@masci masci masci approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rsora @masci