Skip to content

fix: theme service binding #1743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2022
Merged

fix: theme service binding #1743

merged 1 commit into from
Dec 7, 2022

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Dec 6, 2022 •
edited
Loading

Motivation

Copy and use custom VS Code themes in IDE2.

Change description

Fixed dependency injection of the theme service. With the correct theme service binding, IDE2 can access themes from the indexedDB.

To verify:

  • download a VS Code theme VSIX. (I used this for the verification: https://marketplace.visualstudio.com/items?itemName=N7n.n7-vscode-themes),
  • rename the downloaded .vsix to .zip, unarchive it, and copy it under the resources/app/plugins folder. On macOS, it looks like this.
    Screen Shot 2022-12-06 at 16 40 50
  • Start IDE2 and open the settings dialog,
  • You can see the new themes in the themes dropdown.
    Screen Shot 2022-12-06 at 16 42 48
  • When you select it, it works.
  • Restart IDE2. The current custom theme is what you have selected.

Other information

Closes #1742

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

fix: theme service binding
a749407 
cleaned up unused symbol

closes #1742

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Dec 6, 2022
@kittaakos kittaakos requested a review from per1234 December 6, 2022 15:44
per1234
per1234 approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified this fixes #1742

Thanks Akos!

@kittaakos kittaakos merged commit c4172ee into main Dec 7, 2022
@kittaakos kittaakos deleted the #1742 branch December 7, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Theme Extension Ignored
2 participants
@kittaakos @per1234