Skip to content

ATL-1136: Add .adoc and .md file support #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2021
Merged

ATL-1136: Add .adoc and .md file support #263

merged 1 commit into from
Mar 29, 2021

Conversation

fstasi
Copy link
Contributor

@fstasi fstasi commented Mar 24, 2021 •
edited
Loading

This PR add support to create and view .md and .adoc files in IDE2. It also fix .S file extension (see #218 )

Note: this PR alone do not solve the fact the IDE2 do not open automatically .md and .adoc files belonging to a sketch. That will be handled in a separate PR addressing ATL-1152

How to test

  • open IDE2
  • create a new tab using the top right button
  • give it a name and and extension .md or .adoc

Demo

doc-file-support

Tasks

ATL-1136
fixes #218

@fstasi fstasi requested a review from kittaakos March 24, 2021 10:56
@kittaakos
Copy link
Contributor

The CLI does not yet support these files, there is not much to review here.

kittaakos
kittaakos reviewed Mar 24, 2021
View reviewed changes
@kittaakos
Copy link
Contributor

Could you please cover #218 in this PR?

@fstasi fstasi force-pushed the atl-1136--documentation-file-extensions branch from c19d23b to d9afede Compare March 25, 2021 11:29
@fstasi fstasi linked an issue Mar 25, 2021 that may be closed by this pull request
Assembly language file extension has the wrong case #218
Closed
ubidefeo
ubidefeo approved these changes Mar 25, 2021
View reviewed changes
Copy link

@ubidefeo ubidefeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested also against #218
LGTM

@fstasi fstasi merged commit b17b7a6 into main Mar 29, 2021
@kittaakos kittaakos deleted the atl-1136--documentation-file-extensions branch April 8, 2021 12:42
@per1234 per1234 added topic: code Related to content of the project itself type: enhancement Proposed improvement labels Oct 25, 2021
@per1234 per1234 mentioned this pull request Oct 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubidefeo ubidefeo ubidefeo approved these changes

+1 more reviewer

@kittaakos kittaakos kittaakos left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assembly language file extension has the wrong case
4 participants
@fstasi @kittaakos @ubidefeo @per1234