Make dedicated package for release archive handling #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the initial minimal refactoring for what will eventually be a more significant package.
The change resulted in an import cycle in `internal/libraries/git_integration_test.go`. I changed its package name as a workaround.
silvanocerza
suggested changes
Aug 25, 2021
Previously, the compilation of the regular expression used to convert the library name to the release archive root folder and file name was done inside the function, which caused it to be compiled redundantly for every subsequent call. Moving it to the package scope improves the function's efficiency.
silvanocerza
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The planned addition of Library Manager content maintenance capabilities to the tool requires that all data related to the library release archives be accessible via the internal API.
I found that the Git clone path naming had been used unnecessarily as the basis for the archive paths naming, even though the end goal was to base it on the library repository name. They are based on this URL to different extents, so this really made no sense.