Skip to content

Refactor code to remove old dependency #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2022
Merged

Refactor code to remove old dependency #84

merged 1 commit into from
Jan 17, 2022

Conversation

silvanocerza
Copy link
Contributor

This PR refactors the code to remove a depedency to an old dead ugly library arduino/golang-concurrent-workers.

@silvanocerza silvanocerza added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Oct 11, 2021
@silvanocerza silvanocerza requested a review from a team October 11, 2021 14:08
@silvanocerza silvanocerza force-pushed the scerza/remove-dependency branch 2 times, most recently from fdff75c to 1e0a357 Compare October 13, 2021 08:22
@codecov-commenter
Copy link

Codecov Report

Merging #84 (1e0a357) into main (f916520) will increase coverage by 0.41%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   40.82%   41.24%   +0.41%     
==========================================
  Files          26       26              
  Lines        1477     1462      -15     
==========================================
  Hits          603      603              
+ Misses        817      802      -15     
  Partials       57       57
Flag Coverage Δ
unit 41.24% <0.00%> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/command/sync/sync.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f916520...1e0a357. Read the comment docs.

cmaglie
cmaglie approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@cmaglie cmaglie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏼 I suggest a test run if you didn't already.

@silvanocerza silvanocerza force-pushed the scerza/remove-dependency branch from 1e0a357 to 1124906 Compare October 22, 2021 12:26
@silvanocerza silvanocerza merged commit 49dc48b into main Jan 17, 2022
@silvanocerza silvanocerza deleted the scerza/remove-dependency branch January 17, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaglie cmaglie cmaglie approved these changes

Assignees

@silvanocerza silvanocerza

Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silvanocerza @codecov-commenter @cmaglie