Skip to content

Fix action not downloading correct version on ARM #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 3, 2020
Merged

Fix action not downloading correct version on ARM #13

merged 2 commits into from
Aug 3, 2020

Conversation

silvanocerza
Copy link
Contributor

@silvanocerza silvanocerza commented Jul 31, 2020 •
edited by rsora
Loading

Fixes #7

@silvanocerza silvanocerza requested a review from a team July 31, 2020 13:55
@silvanocerza silvanocerza self-assigned this Jul 31, 2020
rsora
rsora approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@rsora rsora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I would like @umbynos to make a quick test to see if we really solved his issue!

@rsora rsora requested a review from umbynos July 31, 2020 14:39
@umbynos
Copy link
Contributor

umbynos commented Jul 31, 2020

Apparently with x86 arch is working (workflow run), but there are still problems with arm architecture (workflow run). Running file command on the automatically downloaded executable shows /home/tom/actions-runner/_work/_tool/arduino-cli/0.11.0/arm/arduino-cli: ELF 32-bit LSB executable, Intel 80386, version 1 (SYSV), statically linked, stripped

@umbynos
Copy link
Contributor

umbynos commented Jul 31, 2020

Sidenote: using installer works without problems but obviously does not use the action

@silvanocerza silvanocerza force-pushed the scerza/arm-installation branch from c326562 to e918087 Compare August 3, 2020 10:34
umbynos
umbynos approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♾️

@silvanocerza silvanocerza merged commit 3126a38 into master Aug 3, 2020
@silvanocerza silvanocerza deleted the scerza/arm-installation branch August 3, 2020 12:14
@rsora rsora added the type: imperfection Perceived defect in any part of project label Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umbynos umbynos umbynos approved these changes

@rsora rsora rsora approved these changes

Assignees

@silvanocerza silvanocerza

Labels
type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not working on arm architecture
3 participants
@silvanocerza @umbynos @rsora