Skip to content

API: set advertising param functions return success #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions src/local/BLELocalDevice.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -184,34 +184,34 @@ int BLELocalDevice::rssi()
return 127;
}

void BLELocalDevice::setAdvertisedServiceUuid(const char* advertisedServiceUuid)
bool BLELocalDevice::setAdvertisedServiceUuid(const char* advertisedServiceUuid)
{
_advertisingData.setAdvertisedServiceUuid(advertisedServiceUuid);
return _advertisingData.setAdvertisedServiceUuid(advertisedServiceUuid);
}

void BLELocalDevice::setAdvertisedService(const BLEService& service)
bool BLELocalDevice::setAdvertisedService(const BLEService& service)
{
setAdvertisedServiceUuid(service.uuid());
return setAdvertisedServiceUuid(service.uuid());
}

void BLELocalDevice::setAdvertisedServiceData(uint16_t uuid, const uint8_t data[], int length)
bool BLELocalDevice::setAdvertisedServiceData(uint16_t uuid, const uint8_t data[], int length)
{
_advertisingData.setAdvertisedServiceData(uuid, data, length);
return _advertisingData.setAdvertisedServiceData(uuid, data, length);
}

void BLELocalDevice::setManufacturerData(const uint8_t manufacturerData[], int manufacturerDataLength)
bool BLELocalDevice::setManufacturerData(const uint8_t manufacturerData[], int manufacturerDataLength)
{
_advertisingData.setManufacturerData(manufacturerData, manufacturerDataLength);
return _advertisingData.setManufacturerData(manufacturerData, manufacturerDataLength);
}

void BLELocalDevice::setManufacturerData(const uint16_t companyId, const uint8_t manufacturerData[], int manufacturerDataLength)
bool BLELocalDevice::setManufacturerData(const uint16_t companyId, const uint8_t manufacturerData[], int manufacturerDataLength)
{
_advertisingData.setManufacturerData(companyId, manufacturerData, manufacturerDataLength);
return _advertisingData.setManufacturerData(companyId, manufacturerData, manufacturerDataLength);
}

void BLELocalDevice::setLocalName(const char *localName)
bool BLELocalDevice::setLocalName(const char *localName)
{
_scanResponseData.setLocalName(localName);
return _scanResponseData.setLocalName(localName);
}

void BLELocalDevice::setAdvertisingData(BLEAdvertisingData& advertisingData)
Expand Down
12 changes: 6 additions & 6 deletions src/local/BLELocalDevice.h
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,12 @@ class BLELocalDevice {

virtual int rssi();

virtual void setAdvertisedServiceUuid(const char* advertisedServiceUuid);
virtual void setAdvertisedService(const BLEService& service);
virtual void setAdvertisedServiceData(uint16_t uuid, const uint8_t data[], int length);
virtual void setManufacturerData(const uint8_t manufacturerData[], int manufacturerDataLength);
virtual void setManufacturerData(const uint16_t companyId, const uint8_t manufacturerData[], int manufacturerDataLength);
virtual void setLocalName(const char *localName);
virtual bool setAdvertisedServiceUuid(const char* advertisedServiceUuid);
virtual bool setAdvertisedService(const BLEService& service);
virtual bool setAdvertisedServiceData(uint16_t uuid, const uint8_t data[], int length);
virtual bool setManufacturerData(const uint8_t manufacturerData[], int manufacturerDataLength);
virtual bool setManufacturerData(const uint16_t companyId, const uint8_t manufacturerData[], int manufacturerDataLength);
virtual bool setLocalName(const char *localName);

virtual void setAdvertisingData(BLEAdvertisingData& advertisingData);
virtual void setScanResponseData(BLEAdvertisingData& scanResponseData);
Expand Down