Bugfix: prevent reference counting from accessing freed memory #238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
BLELocalAttribute
andBLERemoteAttribute
classes implement a rudimentary reference counting mechanism:However,
_refCount
is an instance variable so every call torelease()
on a pointer that was already deleted will try to access freed memory, defeating the purpose of refcounting. A more modern solution would be to replace this withstd::shared_ptr
, but this pull request provides a minimalistic fix based on making_refCount
a static class variable that lives outside the lifecycle of the instance.I noticed this issue after merging #237.