Skip to content

Please make a new release #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brentru opened this issue Aug 9, 2022 · 6 comments
Closed

Please make a new release #138

brentru opened this issue Aug 9, 2022 · 6 comments
Labels
conclusion: resolved Issue was resolved topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement

Comments

@brentru
Copy link

brentru commented Aug 9, 2022 •
edited
Loading

The latest ESP32 BSP (2.0.4) increases the compiler warn level in which causes compilation with this library to fail due to the following errors:

esp32:esp32   2.0.4   /home/runner/.arduino15/packages/esp32/hardware/esp32/2.0.4
  /home/runner/Arduino/libraries/ArduinoHttpClient/src/HttpClient.cpp: In member function 'int HttpClient::startRequest(const char*, const char*, const char*, int, const byte*)':
  /home/runner/Arduino/libraries/ArduinoHttpClient/src/HttpClient.cpp:87:61: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
               if (!iClient->connect(iServerName, iServerPort) > 0)
                                                               ^
  /home/runner/Arduino/libraries/ArduinoHttpClient/src/HttpClient.cpp:87:17: note: add parentheses around left hand side expression to silence this warning
               if (!iClient->connect(iServerName, iServerPort) > 0)
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                   (                                          )
  /home/runner/Arduino/libraries/ArduinoHttpClient/src/HttpClient.cpp:97:[64](https://github.com/brentru/Adafruit_IO_Arduino/runs/7751465143?check_suite_focus=true#step:7:65): error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]
               if (!iClient->connect(iServerAddress, iServerPort) > 0)
                                                                  ^
  /home/runner/Arduino/libraries/ArduinoHttpClient/src/HttpClient.cpp:97:17: note: add parentheses around left hand side expression to silence this warning
               if (!iClient->connect(iServerAddress, iServerPort) > 0)
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                   (                                             )
  cc1plus: some warnings being treated as errors

The -Werror=logical-not-parentheses warning has been fixed in the latest master branch (here) as of commit 9a5afdf, but this fix has not yet been released.

@per1234 @aentinger - Could you please cut a new release for this library?
@brentru brentru mentioned this issue Aug 9, 2022
Merged
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself topic: infrastructure Related to project infrastructure and removed topic: code Related to content of the project itself labels Aug 9, 2022
@brentru
Copy link
Author

brentru commented Oct 3, 2022

@per1234 Hi - what's the status on cutting a release from master as this is still impacting ESP32 BSP 2.0.5?

@per1234
Copy link

per1234 commented Oct 3, 2022

Hi @brentru. My role in this project is more on the triage end of things. I am not in a position to decide about making releases.

Perhaps one of the project's other maintainers will be able to answer your question.

Regards, Per

@brentru
Copy link
Author

brentru commented Oct 4, 2022 •
edited
Loading

@per1234 Thank you for the clarification! Is @Rocketct the sole maintainer? If so, @Rocketct - could you please cut a new release?

@anyonecan
Copy link

I find this or a similar problem with 2.0.9. Has a version of the fix been implemented in a release?

@Rotzbua
Copy link

Rotzbua commented Jul 15, 2023

For platformio users change the dependency to (current) latest commit:

- arduino-libraries/ArduinoHttpClient@0.4.0
+ https://github.com/arduino-libraries/ArduinoHttpClient.git#6dc486747820d6544b41747c68c6b748f888d661

@per1234 per1234 changed the title Unable to compile HTTPClient for ESP32 (BSP 2.0.4) Please make a new release Jul 15, 2023
@per1234 per1234 added type: enhancement Proposed improvement and removed type: imperfection Perceived defect in any part of project labels Jul 15, 2023
@aentinger
Copy link

Done, see here.

Sorry, I haven't really gotten much to do with this library either, however from my general knowledge I consider it safe to release a new version.

@per1234 per1234 added the conclusion: resolved Issue was resolved label Jul 17, 2023
@Rotzbua Rotzbua mentioned this issue Jul 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
conclusion: resolved Issue was resolved topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@brentru @aentinger @Rotzbua @per1234 @anyonecan