Skip to content

Fixed segfault when initializing TCP server. "Client" is 0 there. #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 22, 2021
Merged

Fixed segfault when initializing TCP server. "Client" is 0 there. #76

merged 2 commits into from
Dec 22, 2021

Conversation

kscholty
Copy link
Contributor

Issue #75 describes a crash wne a ModbusTCPServer is initialized.
This is a fix for that issue.

@CLAassistant
Copy link

CLAassistant commented Nov 19, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

Memory usage change @ 28456d7

Board flash % RAM for global variables %
arduino:avr:leonardo 🔺 0 - +10 0.0 - +0.03 0 - 0 0.0 - 0.0
arduino:mbed:envie_m7 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed:nano33ble 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:megaavr:uno2018:mode=off 🔺 0 - +10 0.0 - +0.02 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 🔺 0 - +8 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/RTU/ModbusRTUClientKitchenSink
flash		 % examples/RTU/ModbusRTUClientKitchenSink
RAM for global variables		 % examples/RTU/ModbusRTUClientToggle
flash		 % examples/RTU/ModbusRTUClientToggle
RAM for global variables		 % examples/RTU/ModbusRTUServerKitchenSink
flash		 % examples/RTU/ModbusRTUServerKitchenSink
RAM for global variables		 % examples/RTU/ModbusRTUServerLED
flash		 % examples/RTU/ModbusRTUServerLED
RAM for global variables		 % examples/RTU/ModbusRTUTemperatureSensor
flash		 % examples/RTU/ModbusRTUTemperatureSensor
RAM for global variables		 % examples/TCP/EthernetModbusClientToggle
flash		 % examples/TCP/EthernetModbusClientToggle
RAM for global variables		 % examples/TCP/EthernetModbusServerLED
flash		 % examples/TCP/EthernetModbusServerLED
RAM for global variables		 % examples/TCP/WiFiModbusClientToggle
flash		 % examples/TCP/WiFiModbusClientToggle
RAM for global variables		 % examples/TCP/WiFiModbusServerLED
flash		 % examples/TCP/WiFiModbusServerLED
RAM for global variables		 %
arduino:avr:leonardo 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 10 0.03 0 0.0 10 0.03 0 0.0
arduino:mbed:envie_m7 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed:nano33ble 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:megaavr:uno2018:mode=off 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 10 0.02 0 0.0 10 0.02 0 0.0 10 0.02 0 0.0 10 0.02 0 0.0
arduino:samd:mkrwifi1010 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0
Click for full report CSV 
Board,examples/RTU/ModbusRTUClientKitchenSink<br>flash,%,examples/RTU/ModbusRTUClientKitchenSink<br>RAM for global variables,%,examples/RTU/ModbusRTUClientToggle<br>flash,%,examples/RTU/ModbusRTUClientToggle<br>RAM for global variables,%,examples/RTU/ModbusRTUServerKitchenSink<br>flash,%,examples/RTU/ModbusRTUServerKitchenSink<br>RAM for global variables,%,examples/RTU/ModbusRTUServerLED<br>flash,%,examples/RTU/ModbusRTUServerLED<br>RAM for global variables,%,examples/RTU/ModbusRTUTemperatureSensor<br>flash,%,examples/RTU/ModbusRTUTemperatureSensor<br>RAM for global variables,%,examples/TCP/EthernetModbusClientToggle<br>flash,%,examples/TCP/EthernetModbusClientToggle<br>RAM for global variables,%,examples/TCP/EthernetModbusServerLED<br>flash,%,examples/TCP/EthernetModbusServerLED<br>RAM for global variables,%,examples/TCP/WiFiModbusClientToggle<br>flash,%,examples/TCP/WiFiModbusClientToggle<br>RAM for global variables,%,examples/TCP/WiFiModbusServerLED<br>flash,%,examples/TCP/WiFiModbusServerLED<br>RAM for global variables,%
arduino:avr:leonardo,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,10,0.03,0,0.0,10,0.03,0,0.0
arduino:mbed:envie_m7,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,
arduino:mbed:nano33ble,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,
arduino:megaavr:uno2018:mode=off,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,10,0.02,0,0.0,10,0.02,0,0.0,10,0.02,0,0.0,10,0.02,0,0.0
arduino:samd:mkrwifi1010,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0

@per1234 per1234 linked an issue Nov 21, 2021 that may be closed by this pull request
Arduino: Crash when calling ModbusTCPServer.begin() #75
Closed
@per1234 per1234 added the type: imperfection Perceived defect in any part of project label Nov 21, 2021
@github-actions
Copy link

Memory usage change @ 3aac235

Board flash % RAM for global variables %
arduino:avr:leonardo 🔺 0 - +10 0.0 - +0.03 0 - 0 0.0 - 0.0
arduino:mbed:envie_m7 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed:nano33ble 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:megaavr:uno2018:mode=off 🔺 0 - +10 0.0 - +0.02 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 🔺 0 - +8 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/RTU/ModbusRTUClientKitchenSink
flash		 % examples/RTU/ModbusRTUClientKitchenSink
RAM for global variables		 % examples/RTU/ModbusRTUClientToggle
flash		 % examples/RTU/ModbusRTUClientToggle
RAM for global variables		 % examples/RTU/ModbusRTUServerKitchenSink
flash		 % examples/RTU/ModbusRTUServerKitchenSink
RAM for global variables		 % examples/RTU/ModbusRTUServerLED
flash		 % examples/RTU/ModbusRTUServerLED
RAM for global variables		 % examples/RTU/ModbusRTUTemperatureSensor
flash		 % examples/RTU/ModbusRTUTemperatureSensor
RAM for global variables		 % examples/TCP/EthernetModbusClientToggle
flash		 % examples/TCP/EthernetModbusClientToggle
RAM for global variables		 % examples/TCP/EthernetModbusServerLED
flash		 % examples/TCP/EthernetModbusServerLED
RAM for global variables		 % examples/TCP/WiFiModbusClientToggle
flash		 % examples/TCP/WiFiModbusClientToggle
RAM for global variables		 % examples/TCP/WiFiModbusServerLED
flash		 % examples/TCP/WiFiModbusServerLED
RAM for global variables		 %
arduino:avr:leonardo 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 10 0.03 0 0.0 10 0.03 0 0.0
arduino:mbed:envie_m7 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:mbed:nano33ble 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:megaavr:uno2018:mode=off 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 10 0.02 0 0.0 10 0.02 0 0.0 10 0.02 0 0.0 10 0.02 0 0.0
arduino:samd:mkrwifi1010 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0
Click for full report CSV 
Board,examples/RTU/ModbusRTUClientKitchenSink<br>flash,%,examples/RTU/ModbusRTUClientKitchenSink<br>RAM for global variables,%,examples/RTU/ModbusRTUClientToggle<br>flash,%,examples/RTU/ModbusRTUClientToggle<br>RAM for global variables,%,examples/RTU/ModbusRTUServerKitchenSink<br>flash,%,examples/RTU/ModbusRTUServerKitchenSink<br>RAM for global variables,%,examples/RTU/ModbusRTUServerLED<br>flash,%,examples/RTU/ModbusRTUServerLED<br>RAM for global variables,%,examples/RTU/ModbusRTUTemperatureSensor<br>flash,%,examples/RTU/ModbusRTUTemperatureSensor<br>RAM for global variables,%,examples/TCP/EthernetModbusClientToggle<br>flash,%,examples/TCP/EthernetModbusClientToggle<br>RAM for global variables,%,examples/TCP/EthernetModbusServerLED<br>flash,%,examples/TCP/EthernetModbusServerLED<br>RAM for global variables,%,examples/TCP/WiFiModbusClientToggle<br>flash,%,examples/TCP/WiFiModbusClientToggle<br>RAM for global variables,%,examples/TCP/WiFiModbusServerLED<br>flash,%,examples/TCP/WiFiModbusServerLED<br>RAM for global variables,%
arduino:avr:leonardo,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,10,0.03,0,0.0,10,0.03,0,0.0
arduino:mbed:envie_m7,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,
arduino:mbed:nano33ble,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,,,,,,,,
arduino:megaavr:uno2018:mode=off,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,10,0.02,0,0.0,10,0.02,0,0.0,10,0.02,0,0.0,10,0.02,0,0.0
arduino:samd:mkrwifi1010,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0

@facchinm
Copy link
Contributor

LGTM, thanks!

@facchinm facchinm merged commit 9cc96f2 into arduino-libraries:master Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Arduino: Crash when calling ModbusTCPServer.begin()
4 participants
@kscholty @CLAassistant @facchinm @per1234