Skip to content

Allow other task to run while waiting #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2022
Merged

Allow other task to run while waiting #68

merged 1 commit into from
Apr 25, 2022

Conversation

mazgch
Copy link
Contributor

@mazgch mazgch commented Apr 10, 2022

This library could be polite and yield while waiting more more stuff to do.
I a multitask system this allows other tasks to do nothing better with the available CPU time.

@CLAassistant
Copy link

CLAassistant commented Apr 10, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

Memory usage change @ a7e69d8

Board flash % RAM for global variables %
arduino:megaavr:uno2018 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkr1000 🔺 +8 - +24 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 🔺 +8 - +16 0.0 - +0.01 0 - 0 0.0 - 0.0
arduino:samd:nano_33_iot 🔺 +8 - +16 0.0 - +0.01 0 - 0 0.0 - 0.0
Click for full report table
Board examples/WiFiAdvancedCallback
flash		 % examples/WiFiAdvancedCallback
RAM for global variables		 % examples/WiFiEcho
flash		 % examples/WiFiEcho
RAM for global variables		 % examples/WiFiEchoCallback
flash		 % examples/WiFiEchoCallback
RAM for global variables		 % examples/WiFiSimpleReceive
flash		 % examples/WiFiSimpleReceive
RAM for global variables		 % examples/WiFiSimpleReceiveCallback
flash		 % examples/WiFiSimpleReceiveCallback
RAM for global variables		 % examples/WiFiSimpleSender
flash		 % examples/WiFiSimpleSender
RAM for global variables		 %
arduino:megaavr:uno2018 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:mkr1000 24 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0 16 0.01 0 0.0
arduino:samd:mkrwifi1010 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0 16 0.01 0 0.0
arduino:samd:nano_33_iot 16 0.01 0 0.0 16 0.01 0 0.0 16 0.01 0 0.0 8 0.0 0 0.0 8 0.0 0 0.0 16 0.01 0 0.0
Click for full report CSV 
Board,examples/WiFiAdvancedCallback<br>flash,%,examples/WiFiAdvancedCallback<br>RAM for global variables,%,examples/WiFiEcho<br>flash,%,examples/WiFiEcho<br>RAM for global variables,%,examples/WiFiEchoCallback<br>flash,%,examples/WiFiEchoCallback<br>RAM for global variables,%,examples/WiFiSimpleReceive<br>flash,%,examples/WiFiSimpleReceive<br>RAM for global variables,%,examples/WiFiSimpleReceiveCallback<br>flash,%,examples/WiFiSimpleReceiveCallback<br>RAM for global variables,%,examples/WiFiSimpleSender<br>flash,%,examples/WiFiSimpleSender<br>RAM for global variables,%
arduino:megaavr:uno2018,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:mkr1000,24,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,16,0.01,0,0.0
arduino:samd:mkrwifi1010,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,16,0.01,0,0.0
arduino:samd:nano_33_iot,16,0.01,0,0.0,16,0.01,0,0.0,16,0.01,0,0.0,8,0.0,0,0.0,8,0.0,0,0.0,16,0.01,0,0.0

@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Apr 11, 2022
aentinger
aentinger approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@aentinger aentinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aentinger aentinger merged commit 46d65e3 into arduino-libraries:master Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aentinger aentinger aentinger approved these changes

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mazgch @CLAassistant @aentinger @per1234