Provide error message when trying to compile this library for the M4 core. #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facchinm
reviewed
Mar 1, 2023
| @@ -24,6 +24,10 @@ | |||
| * INCLUDE | |||
| **************************************************************************************/ | |||
|
|
|||
| #ifdef ARDUINO_PORTENTA_H7_M4 | |||
| # error "This library on works on the M7 core of any STM32H747 based board (Portenta H7, Giga, X8)." | |||
There was a problem hiding this comment.
X8 target runs on M4, are we sure it works there too?
There was a problem hiding this comment.
Mistake in my thinking. I thought it doesn't work there, but then had a logic toogle in my brain. Will fix it.
There was a problem hiding this comment.
Hang on, not actually a mistake, but a bit redundant, since you can't target the M7 on the H747 of the X8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.