Skip to content

Add option to use nullptr and make onDetect safer #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add option to use nullptr and make onDetect safer #9

wants to merge 3 commits into from

Conversation

aliphys
Copy link
Contributor

@aliphys aliphys commented Jun 12, 2024

Closes #8

@aliphys aliphys marked this pull request as ready for review June 13, 2024 09:28
leonardocavagnis
leonardocavagnis reviewed Jun 13, 2024
View reviewed changes
Copy link
Contributor

@leonardocavagnis leonardocavagnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine!
What do you think about calling detach in the end function?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardocavagnis leonardocavagnis leonardocavagnis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not possible to detach interrupt
2 participants
@aliphys @leonardocavagnis