-
Notifications
You must be signed in to change notification settings - Fork 3
Add JWS utility #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JWS utility #26
Conversation
Memory usage change @ 916049c
Click for full report table
Click for full report CSV
|
916049c
to
4900feb
Compare
Memory usage change @ 4900feb
Click for full report table
Click for full report CSV
|
src/utility/SElementBase64.h
Outdated
namespace arduino { namespace b64 { | ||
|
||
String urlEncode(const byte in[], unsigned int length); | ||
String encode(const byte in[], unsigned int length, const char* prefix, const char* suffix); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why don't we define only encode this way? It seems a bit redundant the definition
String encode(const byte in[], unsigned int length, const char* prefix, const char* suffix); | |
String encode(const byte in[], unsigned int length, const char* prefix=nullptr, const char* suffix=nullptr); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this two functions are also using a different alphabet https://datatracker.ietf.org/doc/html/rfc4648#section-5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
encode is also adding \n so i've renamed it to pemEncode
a572ec0
to
bc3a4a2
Compare
Memory usage change @ bc3a4a2
Click for full report table
Click for full report CSV
|
bc3a4a2
to
9ec6dc4
Compare
Memory usage change @ 9ec6dc4
Click for full report table
Click for full report CSV
|
No description provided.