Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @alicederyn as an approver #1280

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Add @alicederyn as an approver #1280

merged 3 commits into from
Nov 28, 2024

Conversation

sambhav
Copy link
Collaborator

@sambhav sambhav commented Nov 28, 2024

These are all the PRs contributed by Alice - https://github.com/argoproj-labs/hera/pulls?q=+is%3Apr+author%3Aalicederyn+ and these are reviews - https://github.com/argoproj-labs/hera/pulls?q=is%3Apr+commenter%3Aalicederyn+-author%3Aalicederyn+

She has made significant contributions to the project and I would like to nominate her as an approver.

For more details on the requirements/responsibilities and privileges, please see https://github.com/argoproj-labs/hera/blob/main/GOVERNANCE.md#approvers

These are all the PRs contributed by Alice - https://github.com/argoproj-labs/hera/pulls/alicederyn and these are reviews - https://github.com/argoproj-labs/hera/pulls?q=is%3Aopen+is%3Apr+commenter%3Aalicederyn+-author%3Aalicederyn

She has made significant contributions to the project and I would like to nominate her as an approver.

For more details on the requirements/responsibilities and privileges, please see https://github.com/argoproj-labs/hera/blob/main/GOVERNANCE.md#approvers

Signed-off-by: Sambhav Kothari <skothari44@bloomberg.net>
@sambhav sambhav added the type:skip-changelog A change that does not require a changelog entry label Nov 28, 2024
Signed-off-by: Sambhav Kothari <skothari44@bloomberg.net>
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.2%. Comparing base (583d858) to head (1bb3db5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1280   +/-   ##
=====================================
  Coverage   86.2%   86.2%           
=====================================
  Files         60      60           
  Lines       4102    4102           
  Branches     657     657           
=====================================
  Hits        3538    3538           
  Misses       392     392           
  Partials     172     172           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flaviuvadan
Copy link
Collaborator

Very exciting! Thank you @alicederyn for all of your contributions!

Copy link
Collaborator

@elliotgunton elliotgunton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go! 🚀

@sambhav sambhav enabled auto-merge (squash) November 28, 2024 14:52
@sambhav sambhav merged commit f8550f0 into main Nov 28, 2024
25 checks passed
@sambhav sambhav deleted the sambhav-patch-1 branch November 28, 2024 15:04
@alicederyn
Copy link
Collaborator

Thank you everyone!!! Excited to see where we go next!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:skip-changelog A change that does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants