-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @alicederyn as an approver #1280
Conversation
These are all the PRs contributed by Alice - https://github.com/argoproj-labs/hera/pulls/alicederyn and these are reviews - https://github.com/argoproj-labs/hera/pulls?q=is%3Aopen+is%3Apr+commenter%3Aalicederyn+-author%3Aalicederyn She has made significant contributions to the project and I would like to nominate her as an approver. For more details on the requirements/responsibilities and privileges, please see https://github.com/argoproj-labs/hera/blob/main/GOVERNANCE.md#approvers Signed-off-by: Sambhav Kothari <skothari44@bloomberg.net>
Signed-off-by: Sambhav Kothari <skothari44@bloomberg.net>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1280 +/- ##
=====================================
Coverage 86.2% 86.2%
=====================================
Files 60 60
Lines 4102 4102
Branches 657 657
=====================================
Hits 3538 3538
Misses 392 392
Partials 172 172 ☔ View full report in Codecov by Sentry. |
Very exciting! Thank you @alicederyn for all of your contributions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go! 🚀
Thank you everyone!!! Excited to see where we go next! |
These are all the PRs contributed by Alice - https://github.com/argoproj-labs/hera/pulls?q=+is%3Apr+author%3Aalicederyn+ and these are reviews - https://github.com/argoproj-labs/hera/pulls?q=is%3Apr+commenter%3Aalicederyn+-author%3Aalicederyn+
She has made significant contributions to the project and I would like to nominate her as an approver.
For more details on the requirements/responsibilities and privileges, please see https://github.com/argoproj-labs/hera/blob/main/GOVERNANCE.md#approvers