Support Node.js 16 runtime for AWS Lambda #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
package.json
Outdated
| @@ -9,7 +9,7 @@ | |||
| "test": "nyc --statements 100 -- mocha -- --check-leaks --timeout 3000" | |||
| }, | |||
| "dependencies": { | |||
| "aws-sdk": "~2.631.0" | |||
| "aws-sdk": "~2.1055.0" | |||
There was a problem hiding this comment.
Why not?
Suggested change
| "aws-sdk": "~2.1055.0" | |
| "aws-sdk": "^2.1055.0" |
There was a problem hiding this comment.
The idea was to pin it to the version used in the AWS Lambda runtime environment per: https://docs.aws.amazon.com/lambda/latest/dg/lambda-runtimes.html
I'll update it to match the current Node 16 runtime.
|
FYI, I've been using this on Node 16 for 5 months now without any issues. |
Saeger
reviewed
Dec 28, 2022
test/handler.js
Outdated
| }; | ||
| index.handler(event, context, callback, overrides); | ||
| }); | ||
| // it('should report failure for invalid steps', function(done) { |
There was a problem hiding this comment.
This test was not passing when I switched to Node 16. I've made a slight change that resolves the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.