More streamlining, fault tolerance, and coverage increasing #142
Conversation
|
|
||
| def _program_name(self): | ||
| def _program_name(self): # pramga: no cover |
| @@ -22,8 +22,6 @@ | |||
| import pymatbridge as pymat | |||
| from .compat import text_type | |||
|
|
|||
| ipython_version = int(IPython.__version__[0]) | |||
There was a problem hiding this comment.
Probably safer to use IPython.version_info
There was a problem hiding this comment.
Not needed any more, I used a version-agnostic method.
|
There seems to be an issue with the Travis build. If the tests fail, it waits for 10 minutes and times out. |
|
@isbadawi, yeah, I'm not sure what to do about that. The Python 3.4 version had the same behavior even when passing. |
|
We could add a kill switch alarm to make it stop sooner... |
|
Oh great, now they are all hanging... |
|
It looks like the test failure leaves it hanging there. On Mon, Feb 16, 2015 at 9:57 AM, Steven Silvester notifications@github.com
|
|
Hold on before merging, I'm adding two more tests. |
|
The hanging behaviour was a result of me removing |
More streamlining, fault tolerance, and coverage increasing
87 -> 92%, and caught some bugs!