Streamline build process to use a single make and config file #144
Conversation
|
LGTM. You should be able to delete |
|
|
||
| if __name__ == '__main__': | ||
| usage = 'Please specify a valid make target (Matlab or Octave)' | ||
| if len(sys.argv) < 1: |
| else: | ||
| mex = matlab_bin + "/mex" | ||
| paths = "-L%(zmq_lib)s -I%(zmq_inc)s" % cfg | ||
| make_cmd = '"%s" -O %s -lzmq ./src/messenger.c' % (mex, paths) |
There was a problem hiding this comment.
With the quotes around the executable I get an OSError: [Errno 2] No such file or directory on my mac.
There was a problem hiding this comment.
Hmm, looking at the original version it looks like those quotes were there. But yeah I got the same error on Linux with Matlab (must be a windows-only thing).
There was a problem hiding this comment.
Probably just os.system has different semantics than check_output.
There was a problem hiding this comment.
Ah, you reminded me to use shlex.split, which will handle spaces in paths.
There was a problem hiding this comment.
And yes, that does make sense, since we are passing a list of strings.
| try: | ||
| os.remove('messenger.o') | ||
| except OSError: | ||
| os.remove('src/messenger.o') |
There was a problem hiding this comment.
I still get an error here when building for matlab. I ran the mex command manually and it looks like I don't get a .o file anywhere, actually.
Streamline build process to use a single make and config file
No description provided.