Ugh I hate you Coveralls!

Do not merge yet! I have to change messenger.c again.

Good to go. Octave plots were coming back from the dead so I had to add an explicit close all hidden at the start of each eval.

Sorry, please wait again.

Nevermind, I tried to avoid closing the figures by using pause instead of drawnow in messenger.c but the Octave figures still pop up. This is ready to merge.

Just to be sure - these newly compiled messengers are now compiled against zmq 4?

I compiled against libzmq3, since that is what is available via apt-get in Ubuntu 14.04. I'd contrast this to the OSX situation where you have v4 available on Homebrew, and Windows, where you can get the installer on the ZMQ website. (I built against v4 on Windows).

I went in the coveralls settings and changed "Coverage decrease threshold for failure" to "10%", so (if I understand the setting correctly) it should stop failing PRs for reducing coverage by a tiny amount like this. (You should both have access if you'd like to mess with the settings more: https://coveralls.io/r/arokem/python-matlab-bridge).

Anyway, this LGTM. I'll commit new versions of the OS X messengers for Matlab and Octave (built against v4) after merging.

Cool cool. I am working on setting up the messengers right now, so you can
hold off on that.

On Fri, Feb 20, 2015 at 5:15 PM, Ismail Badawi notifications@github.com
wrote:

Merged #150 #150.

—
Reply to this email directly or view it on GitHub
#150 (comment).

Oh sorry! I just pushed them. Feel free to override if you have something you want to add.

No problem. The ones you pushed are compiled against zmq 4? I'll add (as
backup) the zmq 3 ones.

On Fri, Feb 20, 2015 at 5:17 PM, Ismail Badawi notifications@github.com
wrote:

Oh sorry! I just pushed them. Feel free to override if you have something
you want to add.

—
Reply to this email directly or view it on GitHub
#150 (comment)
.

Yep, I built them against 4.0.5.

OK. Working on those zmq3 messngers for the mac. Will have a PR with that
soon.

On Fri, Feb 20, 2015 at 5:21 PM, Ismail Badawi notifications@github.com
wrote:

Yep, I built them against 4.0.5.

—
Reply to this email directly or view it on GitHub
#150 (comment)
.

I should build some zmq 4 ones for linux as well. 

—
Sent from Mailbox

On Fri, Feb 20, 2015 at 8:24 PM, Ariel Rokem notifications@github.com
wrote:

OK. Working on those zmq3 messngers for the mac. Will have a PR with that
soon.
On Fri, Feb 20, 2015 at 5:21 PM, Ismail Badawi notifications@github.com
wrote:

Yep, I built them against 4.0.5.

—
Reply to this email directly or view it on GitHub
#150 (comment)
.

---

Reply to this email directly or view it on GitHub:
#150 (comment)