Skip to content

Fix matlabserver shutdown behavior #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2015
Merged

Fix matlabserver shutdown behavior #169

merged 1 commit into from
Apr 24, 2015
+3 −3

Conversation

blink1073
Copy link
Collaborator

Fixes #168, addresses #164.

I could not find a way to reliably interrupt the Matlab process and recover from it, but at least now Ctrl+C results in a clean shutdown of the Matlab process.

@blink1073 blink1073 mentioned this pull request Mar 14, 2015
Closed
@arokem
Copy link
Owner

arokem commented Apr 24, 2015

Whoops. Sorry that it's taken so long to look at this. Looks good!

arokem added a commit that referenced this pull request Apr 24, 2015
@arokem
Merge pull request #169 from blink1073/cleaner-startup
314d049 
Fix matlabserver shutdown behavior
@arokem arokem merged commit 314d049 into arokem:master Apr 24, 2015
@isbadawi
Copy link
Collaborator

@blink1073 Can you explain why onCleanup is needed here?

I ask because it looks like Octave doesn't like you calling exit or quit inside an onCleanup handler, so this error always gets printed when we exit:

error: quit: not supported in embedded mode
error: called from:
error:    at line -1, column -1
error:   /Users/isbadawi/code/py/python-matlab-bridge/pymatbridge/matlab/matlabserver.m at line 12, column 1

@blink1073
Copy link
Collaborator Author

@isbadawi, it was needed to make sure Matlab actually shut down.

@blink1073
Copy link
Collaborator Author

You could try wrapping it in a try block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When a socket-connected matlab instance is already present mlab.start() creates another matlab instance but connects to the one already available
3 participants
@blink1073 @arokem @isbadawi