Make codebase python3 compatible. #79
Merged
+35
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think that this URLError is actually a remnant from the previous webserver model of pymatbridge. I am currently trying things out, to see what we should replace this with. |
|
OK - I couldn't get that error to be raised, no matter what I tried. Let's go with deprecating it, unless we start running into it again. Other than that - looks good! Thanks for doing this |
arokem
added a commit
that referenced
this pull request
Aug 18, 2014
Make codebase python3 compatible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address #51.
These are the changes:
printstatements with calls toprintfunction.send_stringinstead ofsend. More info here: http://zeromq.github.io/pyzmq/unicode.htmlunicodeandunichr, add acompat.pymodule that defines them appropriately based on python version. Could use six here, but since it was just these two things I didn't think it was worth the extra dependency.urllib2.URLError, which doesn't exist in python3. I couldn't figure out the code path that throws this exception -- I tried running code on a non-startedMatlabinstance, and also starting aMatlabinstance and killing the process manually, but neither triggered it. It was added in 79d2025 -- maybe you remember what causes it? In the meantime I've replaced it with a bareexcept, which is not great.I ran the tests with python 2.7.8 and python 3.4.1 and they all passed in both cases. Let me know if this looks fine.