Make get_variable return None if the var doesn't exist in the workspace. #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine to me! |
|
Thanks for doing this - and thanks @isbadawi for taking a look and helping. Would you mind adding a test (for example, here: https://github.com/arokem/python-matlab-bridge/blob/master/pymatbridge/tests/test_run_code.py) that fails without this fix, and passes once the fix is applied? |
|
Hi @arokem ! There is a test here: https://github.com/dukebody/python-matlab-bridge/blob/b47e5da875fb782df14088262bacb71514c9fe8f/pymatbridge/tests/test_get_variable.py#L38 Is this enough or should we include something in test_run_code.py as well? |
|
Sorry - I must have missed that. Excellent! |
arokem
added a commit
that referenced
this pull request
Oct 27, 2014
Make get_variable return None if the var doesn't exist in the workspace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes bug #91 .