Implement meanvar. Returns the mean and variance of an array #2258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9prady9
reviewed
Aug 4, 2018
| calculated. Default is -1 meaning the first non-zero dim | ||
| */ | ||
| AFAPI void meanvar(array& mean, array& var, const array& in, const array& weights, | ||
| const af_var_bias bias = AF_VARIANCE_POPULATION, const dim_t dim=-1); |
There was a problem hiding this comment.
We should probably port this variance bias enum support to other variance computing functions which currently take a boolean
| is_same_type<T, char >::value, | ||
| float, | ||
| typename elseType<T>::type>::type type; | ||
| }; |
There was a problem hiding this comment.
elseType doesn't seem to be used anywhere else, can't we abridge varOutType to the following?
template<typename T>
struct varOutType {
typedef typename cond_type< is_same_type<T, uintl>::value ||
is_same_type<T, intl>::value ||
is_same_type<T, double>::value,
double, float >::type type;
};There was a problem hiding this comment.
The else type is used to handle the cfloat and cdouble case. Those calls return the same type as the input.
This function performs the same number of operations as regular var but returns the intermediate mean array as well
9prady9
approved these changes
Aug 4, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function performs the same number of operations as regular
var but returns the intermediate mean array as well
Addresses #2136