Skip to content

Fixed unnecessary memcpy during array assignment #2575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2019
Merged

Fixed unnecessary memcpy during array assignment #2575

merged 2 commits into from
Jul 11, 2019

Conversation

ShadyBoukhary
Copy link
Member

@ShadyBoukhary ShadyBoukhary commented Jul 8, 2019 •
edited
Loading

Fixes #2425

@ShadyBoukhary ShadyBoukhary requested a review from umar456 July 8, 2019 21:00
@ShadyBoukhary ShadyBoukhary changed the title Fixed unnecessary device to device memcpy during array assignment Fixed unnecessary memcpy during array assignment Jul 8, 2019
umar456
umar456 requested changes Jul 9, 2019
View reviewed changes
Copy link
Member

@umar456 umar456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I have suggested a couple of minor changes to the comments and variable names.

@ShadyBoukhary ShadyBoukhary requested a review from umar456 July 9, 2019 15:55
@umar456 umar456 merged commit 04c755a into arrayfire:master Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umar456 umar456 umar456 approved these changes

Assignees
No one assigned
Labels
perf
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

assign operations are performing unnecessary memcpys
2 participants
@ShadyBoukhary @umar456