fp16 support: flat, clamp, select_scalar #2583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting this!. Can you make a unit test for this. Check out PR #2572 for some examples. Basically use the half_float::half to create an array. and check the results. |
|
I'm not a C++ person, sorry. Also why do all unary ops for f16 return f32? |
|
I can add the tests in a bit. Unary ops have not been correctly implemented yet. It is something that needs to be fixed. |
|
Some of the tests I added depends on #2572. I will update once I have that merged in. |
|
Rebased and fixed tests. |
umar456
approved these changes
Jul 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.