Let af_approx1 allocate the output array, have af_approx1_v2 accept preallocated outputs #2599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
July 22, 2019 16:58
…nctionality as v2
11779ef to
69db8d7
Compare
umar456
requested changes
Jul 23, 2019
added 4 commits
July 23, 2019 13:33
I ran clang-format on the modified files but left out the specially formatted lines already there, which I assume were written that way to make them easier to read. |
added 5 commits
July 23, 2019 16:22
umar456
approved these changes
Jul 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends #2324 in order to address the concern raised in #2481 (comment). Here,
af_approx1's behavior towards allocating output arrays is reverted to the original (before #2324), where it simply creates a newaf_arrayeach time. However, a new function is added:af_approx1_v2, which implements the same behavior as in #2324 (uses the existing array passed as theoutargument and only allocate if it is null).Here are some screenshots of the added documentation as well:
