Clarify and correct nearest neighbour documentation #2628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9prady9
requested changes
Aug 30, 2019
|
Updated the screenshots after 9d6c602 |
9prady9
requested changes
Sep 3, 2019
|
Updated the screenshots again after 98f2485 |
9prady9
requested changes
Sep 4, 2019
98f2485 to
e02389c
Compare
|
Updated the screenshots after e02389c |
e02389c to
c18555f
Compare
9prady9
approved these changes
Sep 5, 2019
| 0, so a point's coordinates in this case must be specified along dim0, and the | ||
| list of points must be enumerated along dim1. Consequently, if `dist_dim` is 1, | ||
| then a point's coordinates must be specified along dim1, and the list must be | ||
| enumerated along dim0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used
nearestNeighbourrecently and I thought that the documentation needs some clarifications, corrections, and examples. Let me know what you guys think. Screenshots below: